8000 bpo-46841: Inline cache for `BINARY_SUBSCR`. by markshannon · Pull Request #31618 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-46841: Inline cache for BINARY_SUBSCR. #31618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 1, 2022
Merged

bpo-46841: Inline cache for BINARY_SUBSCR. #31618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
465f0c0
Use inline cache for BINARY_SUBSCR. Work in progress.
markshannon Feb 28, 2022
8381b7f
Merge branch 'main' into inline-cache-binary-subscr
markshannon Feb 28, 2022
a9f7043
Finish inlining cache for .
markshannon Feb 28, 2022
a330574
Tidy up
markshannon Feb 28, 2022
e4b0ba0
Address review comments.
markshannon Mar 1, 2022
05787b3
Remove per-code-object-cache and add small per-heap-type cache.
markshannon Mar 1, 2022
956ed1e
Remove unused parameter.
markshannon Mar 1, 2022
0e282f3
Remove unused code.
markshannon Mar 1, 2022
d0c9077
Merge branch 'main' into inline-cache-binary-subscr
markshannon Mar 1, 2022
f667ddb
Clarify comments.
markshannon Mar 1, 2022
2271337
Fix typo.
markshannon Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tidy up
  • Loading branch information
@markshannon
markshannon committed Feb 28, 2022
commit a3305741b27de31d45da363046dbfd2bf7b7e691
18 changes: 4 additions & 14 deletions Include/internal/pycore_code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,13 @@ typedef struct {
} _PyBinaryOpCache;

#define INLINE_CACHE_ENTRIES_BINARY_OP CACHE_ENTRIES(_PyBinaryOpCache)

typedef struct {
_Py_CODEUNIT counter;
} _PyUnpackSequenceCache;









#define INLINE_CACHE_ENTRIES_UNPACK_SEQUENCE \
CACHE_ENTRIES(_PyUnpackSequenceCache)

typedef struct {
_Py_CODEUNIT counter;
Expand All @@ -98,12 +93,7 @@ typedef struct {
_Py_CODEUNIT func_version;
} _PyBinarySubscrCache;


#define INLINE_CACHE_ENTRIES_UNPACK_SEQUENCE \
(sizeof(_PyUnpackSequenceCache) / sizeof(_Py_CODEUNIT))

#define INLINE_CACHE_ENTRIES_BINARY_SUBSCR \
(sizeof(_PyBinarySubscrCache) / sizeof(_Py_CODEUNIT))
#define INLINE_CACHE_ENTRIES_BINARY_SUBSCR CACHE_ENTRIES(_PyBinarySubscrCache)

/* Maximum size of code to quicken, in code units. */
#define MAX_SIZE_TO_QUICKEN 5000
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-02-28-15-46-36.bpo-46841.MDQoty.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use inline cache for :opcode:`BINARY_SUBSCR`.
0