8000 bpo-45975: Simplify some while-loops with walrus operator by nickdrozd · Pull Request #29347 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-45975: Simplify some while-loops with walrus operator #29347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 26, 2022
Merged

bpo-45975: Simplify some while-loops with walrus operator #29347

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ecaeb45
Simplify some while-loops
nickdrozd Oct 26, 2021
4a597aa
Revert distutils changes
nickdrozd Feb 2, 2022
062b0b0
Revert IDLE changes
nickdrozd Feb 2, 2022
a0e49dc
Cut unneeded parentheses
nickdrozd Feb 3, 2022
49aaf58
Revert aifc change
nickdrozd Mar 18, 2022
d2fcc74
One more walrus
nickdrozd Mar 28, 2022
5093f92
Add missing parens
nickdrozd Mar 28, 2022
1583049
Fix whitespace
nickdrozd Mar 29, 2022
b778d04
Revert sre_compile change
nickdrozd Nov 11, 2022
deaf695
Merge branch 'main' into walrus-while
nickdrozd Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert aifc change
  • Loading branch information
@nickdrozd
nickdrozd committed Mar 18, 2022
commit 49aaf58a1cf0a8b7889d901642f7a4c31877a00c
5 changes: 4 additions & 1 deletion Lib/aifc.py
6BBD View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,6 +954,9 @@ def open(f, mode=None):
print("Writing", gn)
with open(gn, 'w') as g:
g.setparams(f.getparams())
while data := f.readframes(1024):
while 1:
data = f.readframes(1024)
if not data:
break
g.writeframes(data)
print("Done.")
0