Revert IDLE changes

python · ethanfurman · Nov 26, 2022 · Oct 26, 2021 · Feb 2, 2022 · Feb 2, 2022
commit 062b0b08f77d4ff76947da5b88048e08fb0e4643
diff --git a/Lib/idlelib/idle_test/test_sidebar.py b/Lib/idlelib/idle_test/test_sidebar.py
@@ -474,7 +474,10 @@ def get_shell_line_y_coords(self):
         index = text.index("@0,0")
         if index.split('.', 1)[1] != '0':
             index = text.index(f"{index} +1line linestart")
-        while (lineinfo := text.dlineinfo(index)) is not None:
+        while True:
+            lineinfo = text.dlineinfo(index)
+            if lineinfo is None:
+                break
             y_coords.append(lineinfo[1])
             index = text.index(f"{index} +1line")
         return y_coords

diff --git a/Lib/idlelib/pyparse.py b/Lib/idlelib/pyparse.py
@@ -179,10 +179,14 @@ def find_good_parse_start(self, is_char_in_string):
         # Peeking back worked; look forward until _synchre no longer
         # matches.
         i = pos + 1
-        while (m := _synchre(code, i)):
-            s, i = m.span()
-            if not is_char_in_string(s):
-                pos = s
+        while 1:
+            m = _synchre(code, i)
+            if m:
+                s, i = m.span()
+                if not is_char_in_string(s):
+                    pos = s
+            else:
+                break
         return pos
    
     def set_lo(self, lo):

diff --git a/Lib/idlelib/replace.py b/Lib/idlelib/replace.py
@@ -158,8 +158,11 @@ def replace_all(self, event=None):
         first = last = None
         # XXX ought to replace circular instead of top-to-bottom when wrapping
         text.undo_block_start()
-        while (res := self.engine.search_forward(
-                text, prog, line, col, wrap=False, ok=ok)):
+        while True:
+            res = self.engine.search_forward(text, prog, line, col,
+                                             wrap=False, ok=ok)
+            if not res:
+                break
             line, m = res
             chars = text.get("%d.0" % line, "%d.0" % (line+1))
             orig = m.group()

diff --git a/Lib/idlelib/run.py b/Lib/idlelib/run.py
@@ -482,7 +482,9 @@ def read(self, size=-1):
         result = self._line_buffer
         self._line_buffer = ''
         if size < 0:
-            while (line := self.shell.readline()):
+            while True:
+                line = self.shell.readline()
+                if not line: break
                 result += line
         else:
             while len(result) < size:

diff --git a/Lib/idlelib/sidebar.py b/Lib/idlelib/sidebar.py
@@ -471,7 +471,10 @@ def update_sidebar(self):
         index = text.index("@0,0")
         if index.split('.', 1)[1] != '0':
             index = text.index(f'{index}+1line linestart')
-        while (lineinfo := text.dlineinfo(index)) is not None:
+        while True:
+            lineinfo = text.dlineinfo(index)
+            if lineinfo is None:
+                break
             y = lineinfo[1]
             prev_newline_tagnames = text_tagnames(f"{index} linestart -1c")
             prompt = (