8000 [3.10] bpo-40128: Fix IDLE autocomplete on macOS (GH-26672) by miss-islington · Pull Request #26684 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-40128: Fix IDLE autocomplete on macOS (GH-26672) #26684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2021
Merged

[3.10] bpo-40128: Fix IDLE autocomplete on macOS (GH-26672) #26684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to 10000
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-40128: Fix IDLE autocomplete on macOS (GH-26672) 
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
  • Loading branch information
@thsubaku9 @miss-islington
thsubaku9 authored and miss-islington committed Jun 11, 2021
commit 1c20f7823604793b2ce0813478f7430184545fbc
1 change: 1 addition & 0 deletions Lib/idlelib/autocomplete_w.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
scrollbar.config(command=listbox.yview)
scrollbar.pack(side=RIGHT, fill=Y)
listbox.pack(side=LEFT, fill=BOTH, expand=True)
acw.update_idletasks() # Need for tk8.6.8 on macOS: #40128.
acw.lift() # work around bug in Tk 8.5.18+ (issue #24570)

# Initialize the listbox selection
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/IDLE/2021-06-11-17-43-39.bpo-40128.7vDN3U.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Mostly fix completions on macOS when not using tcl/tk 8.6.11 (as with 3.9).
The added update_idletask call should be harmless and possibly helpful
otherwise.
0