bpo-40128: Fix IDLE autocomplete on macOS #26672
Conversation
NAN: Fix for allowing autocomplete to work on MacOS IDLE
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Thanks for the PR @thsubaku9, please follow the guidelines here: https://devguide.python.org/pullrequest/#submitting to link the issue to the PR correctly.
|
Kaustubh: I normally do not look as substantive (behavior-changing) diffs until the CLA is recorded as signed. Because completions have been such an issue on macOS, I peeked. Because the fix, which I regard as a bug workaround, is so trivial, I finished the PR and will merge it when CE passes. However, I hope you sign if you have not and look at more bugs. If you do not know, merging a PR branch into main is not needed; you can made the PR directly from the branch. When the branch is checked out, update-merge upstream/main into the branch with the same command used to update local main. |
|
Thanks @thsubaku9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
Sorry @thsubaku9 and @terryjreedy, I had trouble checking out the |
In particular, when running with tk8.6.8, as in PSF 3.9. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 3ec3ee7) Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
|
GH-26683 is a backport of this pull request to the 3.9 branch. |
|
Thanks @thsubaku9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
In particular, when running with tk8.6.8, as in PSF 3.9. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 3ec3ee7) Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
|
GH-26684 is a backport of this pull request to the 3.10 branch. |
Alright, I'll keep this in mind for my future submits. I've signed the CLA but I guess it takes some time to update on the site |
In particular, when running with tk8.6.8, as in PSF 3.9. Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
@terryjreedy |
|
Apparently also with Tcl/Tk 8.6.10, which is the current default. Also broken in my latest install of Python 3.9.7 (not built from source). |
|
See issue. |
|
I noticed that selecting Edit>Show Completions works as expected on Python 3.10.2 and macOS 12.1
But trying the default keyboard shortcut ^S only highlights the edit menu but doesn't work. I understand that it's supposed to be ^space because that's how it works on windows and it also works in macOS after disabling the default behavior for ^space but this doesn't highlight the edit menu. So the mismatch is like this:
|
|
Hey @dvd101x, that looks like a separate issue than the one fixed here. Would you mind opening a new ticket on bugs.python.org with these details? |
|
Yes of course. I saw this referenced on the original issue https://bugs.python.org/issue40128 but it also makes sense for to separate into a different issue. Thanks |
This PR allows autocomplete to work as expected in the MacOS IDLE
https://bugs.python.org/issue40128