8000 bpo-36167: fix an incorrect capitalization by avinassh · Pull Request #14482 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content
10000

bpo-36167: fix an incorrect capitalization #14482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2019
Merged

bpo-36167: fix an incorrect capitalization #14482

merged 1 commit into from
Aug 29, 2019

Conversation

avinassh
Copy link
Contributor
@avinassh avinassh commented Jun 30, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 30, 2019
mangrisano
mangrisano approved these changes Jun 30, 2019
View reviewed changes
Copy link
Contributor
@mangrisano mangrisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mangrisano mangrisano mentioned this pull request Jun 30, 2019
Closed
taleinat
taleinat approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor
@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears grammatically correct, e.g. according to Wikipedia:

Semicolons are followed by a lower case letter, unless that letter would ordinarily be capitalized mid-sentence.

10000
@taleinat taleinat added the skip news label Jul 1, 2019
aeros
aeros approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor
@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to "The" not referring to a title and not being at the start of a sentence, it should not be capitalized in this context. Approved.

@kkaracam kkaracam mentioned this pull request Jul 19, 2019
Closed
@ned-deily ned-deily merged commit 3aa48b8 into python:master Aug 29, 2019
@miss-islington
Copy link
Contributor

Thanks @avinassh for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15574 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-15575 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
@avinassh @miss-islington
bpo-36167: fix an incorrect capitalization (pythonGH-14482)
2f3fa08 
(cherry picked from commit 3aa48b8)

Co-authored-by: avinassh <avinassh@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 29, 2019
@avinassh @miss-islington
bpo-36167: fix an incorrect capitalization (pythonGH-14482)
8a0d2ee 
(cherry picked from commit 3aa48b8)

Co-authored-by: avinassh <avinassh@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 29, 2019
@miss-islington @avinassh
bpo-36167: fix an incorrect capitalization (GH-14482)
e009a91 
(cherry picked from commit 3aa48b8)

Co-authored-by: avinassh <avinassh@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Aug 29, 2019
@miss-islington @avinassh
bpo-36167: fix an incorrect capitalization (GH-14482)
409493d 
(cherry picked from commit 3aa48b8)

Co-authored-by: avinassh <avinassh@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@avinassh @lisroach
bpo-36167: fix an incorrect capitalization (pythonGH-14482)
ccf395b
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@avinassh @DinoV
bpo-36167: fix an incorrect capitalization (pythonGH-14482)
30539ee
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@avinassh @websurfer5
bpo-36167: fix an incorrect capitalization (pythonGH-14482)
390108a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@mangrisano mangrisano mangrisano approved these changes

@aeros aeros aeros approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@avinassh @miss-islington @bedevere-bot @taleinat @mangrisano @aeros @ned-deily @the-knights-who-say-ni
0