10000 gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization by sergey-miryanov · Pull Request #136304 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization #136304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization #136304

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4d648b4
Add tests
fxeqxmulfx Jun 22, 2025
77e9ca7
Organize tests
sergey-miryanov Jun 22, 2025
b6825da
Simplify tests
sergey-miryanov Jun 24, 2025
f62d43e
Remove extra line
sergey-miryanov Jul 4, 2025
398c4f5
Add extra comments
sergey-miryanov Jul 4, 2025
7dd9669
Add tests for checking that weakrefs clears before and after finaliza…
sergey-miryanov Jul 4, 2025
1da73b3
Make tests a little bit reliable
sergey-miryanov Jul 5, 2025
0510539
Simplify tests
sergey-miryanov Jul 5, 2025
50410d6
Use unittest asserts
sergey-miryanov Jul 6, 2025
aa18e74
Move test_clearing_weakrefs_in_gc to test_weakref
sergey-miryanov Jul 8, 2025
7788e55
Apply suggestions from code review
sergey-miryanov Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add extra comments
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Jul 4, 2025
commit 398c4f58f5dd07746a5969d63676e509efa5669d
9 changes: 8 additions & 1 deletion Lib/test/test_gc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,18 +1127,24 @@ def test_something(self):

def test_do_not_cleanup_type_subclasses_before_finalization(self):
# https://github.com/python/cpython/issues/135552
# If we cleanup weakrefs for tp_subclasses before calling
# the finalizer (__del__) then the line `fail = BaseNode.next.next`
# should fail because we are trying to access a subclass
# atribute. But subclass type cache was not properly invalidated.
code = """
class BaseNode:
def __del__(self):
BaseNode.next = BaseNode.next.next
BaseNode.next.next
fail = BaseNode.next.next

class Node(BaseNode):
pass

BaseNode.next = Node()
BaseNode.next.next = Node()
"""
# this test checks garbage collection while interp
# finalization
assert_python_ok("-c", textwrap.dedent(code))

code_inside_function = textwrap.dedent(F"""
Expand All @@ -1147,6 +1153,7 @@ def test():

test()
""")
# this test checks regular garbage collection
assert_python_ok("-c", code_inside_function)


Expand Down
0