8000 gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization by sergey-miryanov · Pull Request #136304 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization #136304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization #136304

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4d648b4
Add tests
fxeqxmulfx Jun 22, 2025
77e9ca7
Organize tests
sergey-miryanov Jun 22, 2025
b6825da
Simplify tests
sergey-miryanov Jun 24, 2025
f62d43e
Remove extra line
sergey-miryanov Jul 4, 2025
398c4f5
Add extra comments
sergey-miryanov Jul 4, 2025
7dd9669
Add tests for checking that weakrefs clears before and after finaliza…
sergey-miryanov Jul 4, 2025
1da73b3
Make tests a little bit reliable
sergey-miryanov Jul 5, 2025
0510539
Simplify tests
sergey-miryanov Jul 5, 2025
50410d6
Use unittest asserts
sergey-miryanov Jul 6, 2025
aa18e74
Move test_clearing_weakrefs_in_gc to test_weakref
sergey-miryanov Jul 8, 2025
7788e55
Apply suggestions from code review
sergey-miryanov Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make tests a little bit reliable
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Jul 5, 2025
commit 1da73b37fe813c77bae73adf9b29f4a898cf3cb8
19 changes: 11 additions & 8 deletions Lib/test/test_gc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,14 +1168,15 @@ def __init__(self):
self._z = weakref.ref(Class, lambda x: None)

def __del__(self):
assert self._z() is None, "Type weakref is not None"
if self._z() is None:
print("Type weakref is None as expected")

Class()

test()
"""
_, _, stderr = assert_python_ok("-c", code)
assert b"Type weakref is not None" not in stderr
_, stdout, _ = assert_python_ok("-c", code)
assert b"Type weakref is None as expected" in stdout

def test_type_weakref_without_callback_should_be_not_none(self):
# This test checks that weakrefs for types without callbacks
Expand All @@ -1190,16 +1191,18 @@ def __init__(self):
self._z = weakref.ref(Class)

def __del__(self):
assert self._x() is None, "Instance weakref is not None"
assert self._z() is Class, "Type weakref is not Class"
if self._x() is None:
print("Instance weakref is None as expected")
if self._z() is Class:
print("Type weakref is Class as expected")

Class()

test()
"""
_, _, stderr = assert_python_ok("-c", code)
assert b"Instance weakref is not None" not in stderr
assert b"Type weakref is not Class" not in stderr
_, stdout, _ = assert_python_ok("-c", code)
assert b"Instance weakref is None as expected" in stdout
assert b"Type weakref is Class as expected" in stdout


class IncrementalGCTests(unittest.TestCase):
Expand Down
Loading
0