8000 gh-135853: add `math.fmax` and `math.fmin` by picnixz · Pull Request #135888 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135853: add math.fmax and math.fmin #135888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 12, 2025
Merged

gh-135853: add math.fmax and math.fmin #135888

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a82d298
add math.fmax and math.fmin
picnixz Jun 24, 2025
afb0a91
address review
picnixz Jun 24, 2025
62597d6
revert un-necessary change
picnixz Jun 24, 2025
a858aa1
Update Lib/test/test_math.py
picnixz Jun 24, 2025
f23a339
Update Lib/test/test_math.py
picnixz Jun 24, 2025
a61eca5
address review and align tests with C11 standard
picnixz Jun 27, 2025
92732bb
Apply suggestions from code review
picnixz Jun 27, 2025
e1bc272
Update Lib/test/test_math.py
picnixz Jun 27, 2025
4e8277f
improve test coverage
picnixz Jun 27, 2025
ba2e77c
remove misleading test
picnixz Jun 27, 2025
c1742a6
align signature style
picnixz Jun 28, 2025
2d3967a
Merge remote-tracking branch 'upstream/main' into feat/math/fmin-fmax…
picnixz Jun 28, 2025
18bdee6
Merge branch 'main' into feat/math/fmin-fmax-135853
picnixz Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove misleading test
  • Loading branch information
@picnixz
picnixz committed Jun 27, 2025
commit ba2e77c33d313ceda6272096c9d43a7fac657578
8 changes: 0 additions & 8 deletions Lib/test/test_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,6 @@ def test_fmax(self):
self.assertEqual(math.fmax(1., 2.), 2.)
self.assertEqual(math.fmax(2., 1.), 2.)

# fmax() does not need to be sensitive to the sign of 0 (§F.10.9.2).
self.assertEqual(math.fmax(+0., -0.), 0.)
self.assertEqual(math.fmax(-0., +0.), 0.)

self.assertEqual(math.fmax(+1., +0.), 1.)
self.assertEqual(math.fmax(+0., +1.), 1.)
self.assertEqual(math.fmax(+1., -0.), 1.)
Expand Down Expand Up @@ -679,10 +675,6 @@ def test_fmin(self):
self.assertEqual(math.fmin(1., 2.), 1.)
self.assertEqual(math.fmin(2., 1.), 1.)

# fmin() does not need to be sensitive to the sign of 0 (§F.10.9.3).
self.assertEqual(math.fmin(+0., -0.), 0.)
self.assertEqual(math.fmin(-0., +0.), 0.)

self.assertEqual(math.fmin(+1., +0.), 0.)
self.assertEqual(math.fmin(+0., +1.), 0.)
self.assertEqual(math.fmin(+1., -0.), 0.)
Expand Down
Loading
0