gh-135853: add math.fmax and math.fmin
#135888
Open
+261
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
math.fmax and math.fminmath.fmax and math.fmin [PoC]
picnixz
commented
Jun 24, 2025
skirpichev
reviewed
Jun 24, 2025
0831229 to
afb0a91
Compare
picnixz
commented
Jun 24, 2025
math.fmax and math.fmin [PoC]math.fmax and math.fmin
picnixz
commented
Jun 24, 2025
vstinner
reviewed
Jun 24, 2025
picnixz
commented
Jun 27, 2025
Misc/NEWS.d/next/Library/2025-06-24-13-30-47.gh-issue-135853.7ejTvK.rst
Outdated
Show resolved
Hide resolved
skirpichev
approved these changes
Jun 27, 2025
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
picnixz
commented
Jun 27, 2025
picnixz
commented
Jun 27, 2025
skirpichev
reviewed
Jun 28, 2025
| @@ -247,6 +249,30 @@ Floating point arithmetic | |||
| .. versionadded:: 3.13 | |||
|
|
|||
|
|
|||
| .. function:: fmax(x, y, /) | |||
There was a problem hiding this comment.
Suggested change
| .. function:: fmax(x, y, /) | |
| .. function:: fmax(x, y) |
Lets not introduce this syntax, unless it's used in other functions of the module docs.
| .. versionadded:: next | ||
|
|
||
|
|
||
| .. function:: fmin(x, y, /) |
There was a problem hiding this comment.
Suggested change
| .. function:: fmin(x, y, /) | |
| .. function:: fmin(x, y) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
math.fminandmath.fmaxas I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument.WDYT of this proposal @skirpichev @rhettinger?
math#135853📚 Documentation preview 📚: https://cpython-previews--135888.org.readthedocs.build/