8000 gh-135853: add `math.fmax` and `math.fmin` by picnixz · Pull Request #135888 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135853: add math.fmax and math.fmin #135888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

gh-135853: add math.fmax and math.fmin #135888

wants to merge 12 commits into from
+259 −2

Conversation

picnixz
Copy link
Member
@picnixz picnixz commented 8000 Jun 24, 2025 •
edited
Loading

I've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument.

WDYT of this proposal @skirpichev @rhettinger?

📚 Documentation preview 📚: https://cpython-previews--135888.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Jun 24, 2025
Open
@picnixz picnixz changed the title gh-135853: add math.fmax and math.fmin gh-135853: add math.fmax and math.fmin [PoC] Jun 24, 2025
picnixz
picnixz commented Jun 24, 2025
View reviewed changes
skirpichev
skirpichev reviewed Jun 24, 2025
View reviewed changes
@picnixz picnixz force-pushed the feat/math/fmin-fmax-135853 branch from 0831229 to afb0a91 Compare June 24, 2025 14:30
picnixz
picnixz commented Jun 24, 2025
View reviewed changes
@picnixz picnixz changed the title gh-135853: add math.fmax and math.fmin [PoC] gh-135853: add math.fmax and math.fmin Jun 24, 2025
picnixz
picnixz commented Jun 24, 2025
View reviewed changes
@picnixz picnixz marked this pull request as ready for review June 24, 2025 15:10
@picnixz picnixz requested a review from skirpichev June 24, 2025 15:10
@picnixz picnixz requested a review from rhettinger June 24, 2025 15:10
vstinner
vstinner reviewed Jun 24, 2025
View reviewed changes
picnixz
picnixz commented Jun 27, 2025
View reviewed changes
@picnixz picnixz requested a review from vstinner June 27, 2025 13:51
vstinner
vstinner approved these changes Jun 27, 2025
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skirpichev
skirpichev approved these changes Jun 27, 2025
View reviewed changes
@picnixz @skirpichev
Apply suggestions from code review
92732bb 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
picnixz
picnixz commented Jun 27, 2025
View reviewed changes
picnixz
picnixz commented Jun 27, 2025
View reviewed changes
@picnixz picnixz self-assigned this Jun 27, 2025
skirpichev
skirpichev reviewed Jun 28, 2025
View reviewed changes
picnixz and others added 2 commits June 28, 2025 10:17
@picnixz @skirpichev
align signature style
c1742a6 
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@picnixz
Merge remote-tracking branch 'upstream/main' into feat/math/fmin-fmax…
2d3967a 
…-135853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@picnixz picnixz

Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @vstinner @skirpichev
0