10000 gh-135571: Guard _hashlib usage in test_hashlib.py by WillChilds-Klein · Pull Request #135572 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135571: Guard _hashlib usage in test_hashlib.py #135572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2025
Merged

gh-135571: Guard _hashlib usage in test_hashlib.py #135572

merged 3 commits into from
Jun 27, 2025
+6 −2

Conversation

WillChilds-Klein
Copy link
Contributor
@WillChilds-Klein WillChilds-Klein commented Jun 16, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jun 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 16, 2025
Open
picnixz
picnixz reviewed Jun 16, 2025
View reviewed changes
@zware zware changed the title gh-135571: Guard _hahslib usage in test_hashlib.py gh-135571: Guard _hashlib usage in test_hashlib.py Jun 16, 2025
@WillChilds-Klein @picnixz
Update Lib/test/test_hashlib.py
1dda3b6 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@WillChilds-Klein WillChilds-Klein requested a review from picnixz June 16, 2025 19:27
picnixz
picnixz approved these changes Jun 22, 2025
View reviewed changes
@picnixz picnixz self-assigned this Jun 27, 2025
@picnixz
Copy link
Member
picnixz commented Jun 27, 2025

Sorry I couldn't find the PR because I didn't assign it to me!

@picnixz picnixz merged commit 065194c into python:main Jun 27, 2025
43 checks passed
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 27, 2025
@miss-islington-app
Copy link

Thanks @WillChilds-Klein for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @WillChilds-Klein for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @WillChilds-Klein and @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 065194c1a971b59547f1bb2cc64760c4bf0ee674 3.13

@miss-islington-app
Copy link

Sorry, @WillChilds-Klein and @picnixz, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 065194c1a971b59547f1bb2cc64760c4bf0ee674 3.14

@picnixz
Copy link
Member
picnixz commented Jun 27, 2025 •
edited
Loading

urgh, I knew it. I'll take care of bps.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 27, 2025
@WillChilds-Klein @picnixz
[3.13] pythongh-135571: Guard _hashlib usage in test_hashlib.py (p…
30a2bb5 
…ythonGH-135572)

(cherry picked from commit 065194c)

Co-authored-by: Will Childs-Klein <willck93@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 27, 2025

GH-136041 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 27, 2025
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 27, 2025
@WillChilds-Klein @picnixz
[3.14] pythongh-135571: Guard _hashlib usage in test_hashlib.py (p…
57a0b98 
…ythonGH-135572)

(cherry picked from commit 065194c)

Co-authored-by: Will Childs-Klein <willck93@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 27, 2025

GH-136042 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

@picnixz picnixz

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillChilds-Klein @picnixz
0