gh-135401: Test AWS-LC 8000 as a cryptography library in CI #135402
Conversation
This reverts commit 7d37e6a.
Misc/NEWS.d/next/Tests/2025-06-11-16-52-49.gh-issue-135401.ccMXmL.rst
Outdated
Show resolved
Hide resolved
.github/workflows/build.yml
Outdated
| with: | ||
| path: ./multissl/aws-lc/${{ matrix.awslc_ver }} | ||
| key: ${{ matrix.os }}-multissl-aws-lc-${{ matrix.awslc_ver }} | ||
| # TODO [childw] can we use env.* instead of env vars here? |
There was a problem hiding this comment.
I'd suggest for the initial version, keep as similar to the OpenSSL job/workflow, and then perhaps update both at once afterwards?
There was a problem hiding this comment.
Fair enough. I'll remove the TODOs. Perhaps we can leave this comment unresolved as a reminder for me to clean up both (if tenable) if/after this PR has been merged.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
…XmL.rst Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Can you cherry-pick 8f4a0eb and make a separate PR please? TiA. |
|
Ok, the failure is because HMAC-SHA3 isn't supported in AWS-LC. I don't know if the ValueError is actually on my side or fired from OpenSSL and I'm just converting the message, but improving that message would be nice. |
|
Looks like it's coming from python. This |
|
Ok so it fell back to the default error message (i.e. there was no reason we could extract) |
Notes
Currently in draft status to test the new workflow. Building AWS-LC, linking the interpreter to it dynamically, and running the
ssltests all appear to work fine. I'm still working on remaining issues intest_hmac.TODO
test_hmacfailures in AWS-LC PR 2484