8000 gh-134235: Import Autocomplete for Builtin Modules by tommix626 · Pull Request #134277 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134235: Import Autocomplete for Builtin Modules #134277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

gh-134235: Import Autocomplete for Builtin Modules #134277

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3cd180e
added enhancement auto completing import with sys builtins
hyoung3 May 19, 2025
035d8dc
revert test changes
tommix626 May 19, 2025
66d7ae6
test: add test for builtin import
tommix626 May 19, 2025
1d395cb
del unneed tests
tommix626 May 19, 2025
e134e01
del more unneed tests
tommix626 May 19, 2025
83a8457
fixbug: add \n on tests
tommix626 May 19, 2025
0fbeb76
clean up unneed test
tommix626 May 19, 2025
3b45160
clean up test case
tommix626 May 19, 2025
019537b
updated NEWS.d
hyoung3 May 19, 2025
b8402eb
change var name for type check
tommix626 May 19, 2025
b53eda0
Merge branch 'fix-issue-134235' of https://github.com/hyoung3/cpython…
tommix626 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load commen 8000 ts.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change var name for type check
  • Loading branch information
@tommix626
tommix626 committed May 19, 2025
commit b8402ebad2c80bf3c699880beaee01887db0f035
6 changes: 3 additions & 3 deletions Lib/_pyrepl/_module_completer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ def find_modules(self, path: str, prefix: str) -> list[str]:
def _find_modules(self, path: str, prefix: str) -> list[str]:
if not path:
# Top-level import (e.g. `import foo<tab>`` or `from foo<tab>`)`
builtins = [name for name in sys.builtin_module_names if name.startswith(prefix)]
modules = [name for _, name, _ in self.global_cache if name.startswith(prefix)]
return sorted(builtins + modules)
builtin_modules = [name for name in sys.builtin_module_names if name.startswith(prefix)]
third_party_modules = [name for _, name, _ in self.global_cache if name.startswith(prefix)]
return sorted(builtin_modules + third_party_modules)

if path.startswith('.'):
# Convert relative path to absolute path
Expand Down
0