8000 gh-134235: Import Autocomplete for Builtin Modules by tommix626 · Pull Request #134277 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134235: Import Autocomplete for Builtin Modules #134277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

gh-134235: Import Autocomplete for Builtin Modules #134277

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3cd180e
added enhancement auto completing import with sys builtins
hyoung3 May 19, 2025
035d8dc
revert test changes
tommix626 May 19, 2025
66d7ae6
test: add test for builtin import
tommix626 May 19, 2025
1d395cb
del unneed tests
tommix626 May 19, 2025
e134e01
del more unneed tests
tommix626 May 19, 2025
83a8457
fixbug: add \n on tests
tommix626 May 19, 2025
0fbeb76
clean up unneed test
tommix626 May 19, 2025
3b45160
clean up test case
tommix626 May 19, 2025
019537b
updated NEWS.d
hyoung3 May 19, 2025
b8402eb
change var name for type check
tommix626 May 19, 2025
b53eda0
Merge branch 'fix-issue-134235' of https://github.com/hyoung3/cpython…
tommix626 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add test for builtin import
  • Loading branch information
@tommix626
tommix626 committed May 19, 2025
commit 66d7ae60c4dd2ff07fb9e545301aa4e3848955d6
53 changes: 53 additions & 0 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,59 @@ def test_import_completions(self):
output = reader.readline()
self.assertEqual(output, expected)

def test_builtin_completion(self):
import importlib
# Make iter_modules() search only the standard library.
# This makes the test more reliable in case there are
# other user packages/scripts on PYTHONPATH which can
# intefere with the completions.
lib_path = os.path.dirname(importlib.__path__[0])
sys.path = [lib_path]

cases = (
# Basic import completion
("import tim\t\n", "import time"),
("import sys\t\t\n", "import sys"), # should pass?
("import mat\t\n", "import math"),
("import bui\t\n", "import builtins"),

# Multiple imports
("import foo, ti\t\n", "import foo, time"),
("import foo, sys\t\n", "import foo, sys"),

# Import with alias
("import time as t\t\n", "import time as t"),
("import math as m, sys\t\n", "import math as m, sys"),

# From-import for functions or attributes
("from math import si\t\n", "from math import sin"),
("from math import co\t\n", "from math import cos"),
("from sys import pat\t\n", "from sys import path"),
("from builtins import str\t\n", "from builtins import str"),

# From-import for modules
("from bui\t\n", "from builtins"),
("from math impo\t\n", "from math import"),
("from sys impo\t\n", "from sys import"),

# Nested completion with tab navigation
("import builti\t\t\n", "import builtins"),
("from builti\t\t\n", "from builtins"),

# tab twice
("import ma\t\t\n", "import math"),
("from ma\t\t\n", "from math"),

# not matching anything
("import ll\t\t\n", "import ll")
)
for code, expected in cases:
with self.subTest(code=code):
events = code_to_events(code)
reader = self.prepare_reader(events, namespace={})
output = reader.readline()
self.assertEqual(output, expected)

def test_relative_import_completions(self):
cases = (
("from .readl\t\n", "from .readline"),
Expand Down
0