fix review idea

Signed-off-by: Manjusaka <me@manjusaka.me>
python · brandtbucher · May 20, 2025 · May 3, 2025 · May 3, 2025 · May 3, 2025
commit cf17d92c012232dee27e786c1b07b5e8e31e6736
diff --git a/Lib/test/test_capi/test_opt.py b/Lib/test/test_capi/test_opt.py
@@ -1926,19 +1926,32 @@ def testfunc(n):
         self.assertNotIn("_GUARD_TOS_INT", uops)
 
     def test_get_len(self):
-        def testfunc(n):
+        def testfunc1(n):
             x = 0
-            a = [1, 2, 3, 4]
             for _ in range(n):
-                match a:
+                match (1, 2, 3, 4):
                     case [_, _, _, _]:
                         x += 1
             return x
-        res, ex = self._run_with_optimizer(testfunc, TIER2_THRESHOLD)
+        res, ex = self._run_with_optimizer(testfunc1, TIER2_THRESHOLD)
+        self.assertEqual(res, TIER2_THRESHOLD)
+        uops = get_opnames(ex)
+        self.assertNotIn("_GUARD_TOS_INT", uops)
+        self.assertIn("_GET_LEN", uops)
+        self.assertIn("_POP_TOP_LOAD_CONST_INLINE_BORROW", uops)
+        def testfunc1(n):
+            x = 0
+            for _ in range(n):
+                match [1, 2, 3, 4]:
+                    case [_, _, _, _]:
+                        x += 1
+            return x
+        res, ex = self._run_with_optimizer(testfunc1, TIER2_THRESHOLD)
         self.assertEqual(res, TIER2_THRESHOLD)
         uops = get_opnames(ex)
         self.assertNotIn("_GUARD_TOS_INT", uops)
         self.assertIn("_GET_LEN", uops)
+        self.assertNotIn("_POP_TOP_LOAD_CONST_INLINE_BORROW", uops)
 
     def test_binary_op_subscr_tuple_int(self):
         def testfunc(n):

@@ -3,6 +3,7 @@
 #include "pycore_uops.h"
 #include "pycore_uop_ids.h"
 #include "internal/pycore_moduleobject.h"
+#include "tupleobject.h"
 
 #define op(name, ...) /* NAME is ignored */
 
@@ -1095,7 +1096,12 @@ dummy_func(void) {
         }
         else {
             assert(tuple_length >= 0);
-            len = sym_new_const(ctx, PyLong_FromLong(tuple_length));
+            PyObject *temp = PyLong_FromLong(tuple_length);
+            if (temp == NULL) {
+                goto error;
+            }
+            len = sym_new_const(ctx, temp);
+            Py_DECREF(temp);
         }
     }
 

diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h