8000 gh-131798: JIT: Narrow the return type of `_GET_LEN` to int by Zheaoli · Pull Request #133345 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-131798: JIT: Narrow the return type of _GET_LEN to int #133345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 20, 2025
Merged

gh-131798: JIT: Narrow the return type of _GET_LEN to int #133345

merged 23 commits into from
May 20, 2025

Conversation

Zheaoli
Copy link
Contributor
@Zheaoli Zheaoli commented May 3, 2025 •
edited by bedevere-app bot
Loading

@Zheaoli Zheaoli requested a review from Fidget-Spinner as a code owner May 3, 2025 14:32
< 8000 a class="d-inline-block" href="/apps/bedevere-app">@bedevere-app bedevere-app bot mentioned this pull request May 3, 2025
Open
tomasr8
tomasr8 reviewed May 3, 2025
View reviewed changes
brandtbucher
brandtbucher requested changes May 6, 2025
View reviewed changes
@bedevere-app
Copy link
bedevere-app bot commented May 6, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Zheaoli added 5 commits May 8, 2025 15:03
@Zheaoli
pythongh-131798: JIT: Narrow the return type of _GET_LEN to int
cabe8f1 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Add news
1f8a607 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix typo
f2f71d9 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix review idea
1662b47 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Fix review idea
52ce698 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli force-pushed the manjusaka/get-len branch from ad1f5df to 52ce698 Compare May 8, 2025 07:07
@Zheaoli
Fix review idea
b1640ed 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author
Zheaoli commented May 8, 2025

I have made the requested changes; please review again.

@bedevere-app
Copy link
bedevere-app bot commented May 8, 2025

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

@Zheaoli
Copy link
Contributor Author
Zheaoli commented May 8, 2025 •
edited
Loading

BTW @brandtbucher @Fidget-Spinner sorry about the force push. I set pull with rebase as default on my environment. I will modify it in next PR(

brandtbucher
brandtbucher requested changes May 8, 2025
View reviewed changes
@bedevere-app
Copy link
bedevere-app bot commented May 8, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

brandtbucher
brandtbucher requested changes May 20, 2025
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just two suggestions for the tests, and one opportunity to optimize more aggressively:

@bedevere-app
Copy link
bedevere-app bot commented May 20, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Zheaoli added 4 commits May 21, 2025 04:12
@Zheaoli
fix review idea
d1e3a2b 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
e0e3745 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
81c4996 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
93e1e86 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author
Zheaoli commented May 20, 2025 •
edited
Loading

I have made the requested changes; please review again

@bedevere-app
Copy link
bedevere-app bot commented May 20, 2025

Thanks for making the requested changes!

@Fidget-Spinner, @brandtbucher: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from brandtbucher May 20, 2025 20:21
@Zheaoli
fix review idea
6b5282f 
Signed-off-by: Manjusaka <me@manjusaka.me>
tomasr8
tomasr8 reviewed May 20, 2025
View reviewed changes
Zheaoli added 2 commits May 21, 2025 04:59
@Zheaoli
fix review idea
2eefeb3 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
9c58f2c 
Signed-off-by: Manjusaka <me@manjusaka.me>
brandtbucher
brandtbucher approved these changes May 20, 2025
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one last suggestion for the test:

Zheaoli added 3 commits May 21, 2025 05:13
@Zheaoli
fix review idea
f9822e9 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
6a06aff 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
fix review idea
6d92614 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli Zheaoli requested a review from brandtbucher May 20, 2025 21:14
@Zheaoli
format code
5cfbad4 
Signed-off-by: Manjusaka <me@manjusaka.me>
@Zheaoli
Copy link
Contributor Author
Zheaoli commented May 20, 2025

Looks good! Just one last suggestion for the test:

Thanks for your patience and review. Learn a lot in this PR. I think I can find a new opcode to write! Thanks again ♥️ @brandtbucher @tomasr8

@brandtbucher brandtbucher merged commit e1c0c45 into python:main May 20, 2025
54 checks passed
@Zheaoli Zheaoli deleted the 7F49 manjusaka/get-len branch May 20, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 left review comments

@brandtbucher brandtbucher brandtbucher approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Assignees
No one assigned
Labels
topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zheaoli @tomasr8 @Fidget-Spinner @brandtbucher @ZeroIntensity
0