10000 gh-130730: Fix multiprocessing test_active_children() by vstinner · Pull Request #130837 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130730: Fix multiprocessing test_active_children() #130837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

gh-130730: Fix multiprocessing test_active_children() #130837

merged 1 commit into from
Mar 4, 2025

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Mar 4, 2025 •
edited by bedevere-app bot
Loading

Replace a sleep with an event: sleep is not a reliable synchronization primitive.

@vstinner
pythongh-130730: Fix multiprocessing test_active_children()
7e30564 
Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
@vstinner vstinner added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 4, 2025
@vstinner vstinner requested a review from gpshead as a code owner March 4, 2025 14:50
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Mar 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 4, 2025
Closed
@colesbury colesbury mentioned this pull request Mar 4, 2025
Closed
@vstinner
Copy link
Member Author
vstinner commented Mar 4, 2025

On Windows, I can easily reproduce the issue with: python -m test test_multiprocessing_spawn.test_threads -m test_active_children -v -F -j20. I reproduce the issue in a few seconds.

With this change, I cannot reproduce the issue anymore. I ran the test for 3 minutes (565 iterations).

@vstinner vstinner enabled auto-merge (squash) March 4, 2025 17:01
@vstinner vstinner merged commit 3dd3675 into python:main Mar 4, 2025
52 checks passed
@vstinner vstinner deleted the test_active_children branch March 4, 2025 17:05
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2025
@vstinner @miss-islington
pythongh-130730: Fix multiprocessing test_active_children() (pythonGH…
b62b9ae 
…-130837)

Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
(cherry picked from commit 3dd3675)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Mar 4, 2025

GH-130845 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 4, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2025
@vstinner @miss-islington
pythongh-130730: Fix multiprocessing test_active_children() (pythonGH…
1a44bc0 
…-130837)

Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
(cherry picked from commit 3dd3675)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Mar 4, 2025

GH-130846 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 4, 2025
vstinner added a commit that referenced this pull request Mar 4, 2025
@miss-islington @vstinner
[3.12] gh-130730: Fix multiprocessing test_active_children() (GH-130837…
45e667c 
…) (#130846)

gh-130730: Fix multiprocessing test_active_children() (GH-130837)

Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
(cherry picked from commit 3dd3675)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Mar 4, 2025
@miss-islington @vstinner
[3.13] gh-130730: Fix multiprocessing test_active_children() (GH-130837…
22d729c 
…) (#130845)

gh-130730: Fix multiprocessing test_active_children() (GH-130837)

Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
(cherry picked from commit 3dd3675)

Co-authored-by: Victor Stinner <vstinner@python.org>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@vstinner @seehwan80
pythongh-130730: Fix multiprocessing test_active_children() (python#1…
db4acd4 
…30837)

Replace a sleep with an event: sleep is not a reliable
synchronization primitive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @colesbury
0