8000 gh-130730: Fix flaky `test_active_children` test by colesbury · Pull Request #130731 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-130730: Fix flaky test_active_children test #130731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-130730: Fix flaky test_active_children test #130731

wants to merge 1 commit into from

Conversation

colesbury
Copy link
Contributor
@colesbury colesbury commented Mar 1, 2025 •
edited by bedevere-app bot
Loading

Use an Event object instead of time.sleep().

@colesbury
pythongh-130730: Fix flaky test_active_children test
28b6274 
Use an Event object instead of time.sleep().
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 1, 2025
@bedevere-app bedevere-app bot mentioned this pull request Mar 1, 2025
Closed
zanieb
zanieb approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor
@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth auditing all the uses of DELTA here, e.g.,

cpython/Lib/test/_test_multiprocessing.py

Lines 1232 to 1233 in 28b6274

# wait to make sure thread starts before we fork a new process
time.sleep(DELTA)

Let me know if you want help with that.

@colesbury
Copy link
Contributor Author

@zanieb - yes, thanks! I'd appreciate help with that.

@colesbury
Copy link
Contributor Author

Closing in favor of #130837

@colesbury colesbury closed this Mar 4, 2025
@vstinner
Copy link
Member
vstinner commented Mar 4, 2025

Sorry, I didn't see that you already created a PR!

@colesbury colesbury deleted the gh-130730-active-children branch March 18, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanieb zanieb zanieb approved these changes

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colesbury @vstinner @zanieb
0