8000 [3.13] gh-127750: Fix functools.singledispatchmethod() by eendebakpt · Pull Request #130029 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.13] gh-127750: Fix functools.singledispatchmethod() #130029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025
Merged

[3.13] gh-127750: Fix functools.singledispatchmethod() #130029

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7606147
Revert gh-107148
eendebakpt Feb 12, 2025
b3064f1
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 12, 2025
77935ab
Merge branch '3.13' into revert_gh_107148
eendebakpt Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Revert gh-107148
  • Loading branch information
@eendebakpt
eendebakpt committed Feb 12, 2025
commit 76061470b9a96093ebf44c8bb94879558bb1392f
16 changes: 0 additions & 16 deletions Lib/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,9 +958,6 @@ def __init__(self, func):
self.dispatcher = singledispatch(func)
self.func = func

import weakref # see comment in singledispatch function
self._method_cache = weakref.WeakKeyDictionary()

def register(self, cls, method=None):
"""generic_method.register(cls, func) -> func

Expand All @@ -969,16 +966,6 @@ def register(self, cls, method=None):
return self.dispatcher.register(cls, func=method)

def __get__(self, obj, cls=None):
if self._method_cache is not None:
try:
_method = self._method_cache[obj]
except TypeError:
self._method_cache = None
except KeyError:
pass
else:
return _method

dispatch = self.dispatcher.dispatch
funcname = getattr(self.func, '__name__', 'singledispatchmethod method')
def _method(*args, **kwargs):
Expand All @@ -991,9 +978,6 @@ def _method(*args, **kwargs):
_method.register = self.register
update_wrapper(_method, self.func)

if self._method_cache is not None:
self._method_cache[obj] = _method

return _method

@property
Expand Down
Loading
0