8000 [3.13] gh-127750: Fix functools.singledispatchmethod() by eendebakpt · Pull Request #130029 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

[3.13] gh-127750: Fix functools.singledispatchmethod() #130029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

eendebakpt
Copy link
Contributor
@eendebakpt eendebakpt commented Feb 12, 2025

In this PR we revert the changes from #107148 (but keep the added tests). This addresses

  • Collisions between different objects with equal __hash__/__eq__
  • Keeping object instances alive

For 3.14+ there are open PRs to address the same issues without the performance regression, but for 3.13 it seems safer to revert the changes (#127750 (comment))

@serhiy-storchaka @Yhg1s

@eendebakpt eendebakpt added the 3.13 bugs and security fixes label Feb 12, 2025
@eendebakpt eendebakpt changed the title gh-127750: Fix singledispatchmethod [3.13] gh-127750: Fix singledispatchmethod Feb 12, 2025
@eendebakpt eendebakpt changed the title [3.13] gh-127750: Fix singledispatchmethod [3.13] gh-127750: Fix functools.singledispatchmethod() Feb 12, 2025
@ZeroIntensity ZeroIntensity removed the 3.13 bugs and security fixes label Feb 12, 2025
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 8f33c7a into python:3.13 Feb 17, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0