8000 gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method by srinivasreddy · Pull Request #129615 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method #129615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test failures
  • Loading branch information
srinivasreddy committed Feb 3, 2025
commit ed4fb8030a8ad67aeaa5f85576a7bc3c19ea4286
4 changes: 2 additions & 2 deletions Lib/test/test_traceback.py
Original file line number Diff line number Diff line change
Expand Up @@ -4498,8 +4498,8 @@ def __getattr__(self, x):
print(qq)
instance = A()
actual = self.get_suggestion(instance, "pop")
self.assertIn("NameError: name 'qq' is not defined", actual)
self.assertEqual(actual.count("NameError: name 'qq' is not defined"), 1)
self.assertRegex(actual, r"NameError:.* name 'qq' is not defined")
self.assertEqual(actual.count("NameError"), 1)

def test_unbound_local_error_does_not_match(self):
def func():
Expand Down
Loading
0