8000 gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method by srinivasreddy · Pull Request #129615 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method #129615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

gh-129605: Fix crashing pyrepl when NameError occurres in __getattr__ method #129615

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2028bd8
Fix crashing pyrepl when NameError occurres in __getattr__ method
srinivasreddy Feb 3, 2025
ed4fb80
Fix test failures
srinivasreddy Feb 3, 2025
c416766
Update the test name
srinivasreddy Feb 3, 2025
d5b2a2f
Fix test failure
srinivasreddy Feb 3, 2025
63da1db
Make the check simple
srinivasreddy Feb 3, 2025
e07c745
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 3, 2025
29090d2
Update NEWS.d description
< 10000 span class="description"> srinivasreddy Feb 3, 2025
418b1b9
Update patch
srinivasreddy Feb 4, 2025
720d6e5
Merge branch 'main' into gh-129605
srinivasreddy Feb 4, 2025
bab4f8b
Merge branch 'main' into gh-129605
srinivasreddy Feb 4, 2025
dfa7a09
Fix Lint failure:
srinivasreddy Feb 4, 2025
c969cca
Address review comments
srinivasreddy Feb 4, 2025
05a9858
Handle __getattribute__ case as well
srinivasreddy Feb 5, 2025
12fd25e
Merge branch 'main' into gh-129605
srinivasreddy Feb 5, 2025
2f25445
Merge branch 'main' into gh-129605
srinivasreddy Feb 5, 2025
af9d076
Update 2025-02-03-16-39-35.gh-issue-129605.sN_0uq.rst
srinivasreddy Feb 5, 2025
842dc93
Add another test for NameError for property function, and also wrap e…
srinivasreddy Feb 5, 2025
f1cb1e3
Update the description
srinivasreddy Feb 5, 2025
2f46caf
Address review comments
srinivasreddy Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test failure
  • Loading branch information
@srinivasreddy
srinivasreddy committed Feb 3, 2025
commit d5b2a2f7653cc4f79e6236f5bd15f30fd45248d8
2 changes: 1 addition & 1 deletion Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4498,7 +4498,7 @@ def __getattr__(self, x):
print(qq)
instance = A()
actual = self.get_suggestion(instance, "pop")
self.assertRegex(actual, r"NameError:.* name 'qq' is not defined")
self.assertRegex(actual, r"NameError.*:.* name 'qq' is not defined")
self.assertEqual(actual.count("NameError"), 1)

def test_unbound_local_error_does_not_match(self):
Expand Down
Loading
0