8000 gh-128002: fix many thread safety issues in asyncio by kumaraditya303 · Pull Request #128147 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-128002: fix many thread safety issues in asyncio #128147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 4, 2025
Merged

gh-128002: fix many thread safety issues in asyncio #128147

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
f3642ae
fix thread safety
kumaraditya303 Dec 21, 2024
1f63b9e
keep working
kumaraditya303 Dec 21, 2024
26e9932
keep working
kumaraditya303 Dec 21, 2024
4381ae2
fix refcounting
kumaraditya303 Dec 21, 2024
b972121
fix refcounting
kumaraditya303 Dec 21, 2024
eeb0273
add asserts
kumaraditya303 Dec 21, 2024
fd1b9cd
more asserts
kumaraditya303 Dec 21, 2024
b628463
more asserts
kumaraditya303 Dec 23, 2024
501b6bb
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Dec 23, 2024
86448af
fix test
kumaraditya303 Dec 23, 2024
303bd9a
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Dec 25, 2024
0e4a775
fix crash by using mutex instead of critical_section
kumaraditya303 Dec 25, 2024
1cb3a6f
fix all_tasks and use critical section as before
kumaraditya303 Dec 31, 2024
195c87d
add supressions
kumaraditya303 Dec 31, 2024
49f3393
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Dec 31, 2024
847da18
remove suppressions for sockets, it is fixed now
kumaraditya303 Jan 1, 2025
41a86a6
merge fixes for socket
kumaraditya303 Jan 1, 2025
2ff2af4
add link to issue in suppressions
kumaraditya303 Jan 2, 2025
5411a44
use list as temp storage for tasks before filtering
kumaraditya303 Jan 2, 2025
1afac5f
fix FutureIter_am_send_lock_held
kumaraditya303 Jan 2, 2025 < 8000 /div>
606ef5c
make it->future immutable
kumaraditya303 Jan 2, 2025
f2ea4c6
Merge branch 'main' of https://github.com/python/cpython into asyncio…
kumaraditya303 Jan 3, 2025
8bd0da7
remove unnecessary incref/decref of task
kumaraditya303 Jan 3, 2025
5030cc6
remove suppressions
kumaraditya303 Jan 4, 2025
2676957
fix comment
kumaraditya303 Jan 4, 2025
6e60222
Update Tools/tsan/suppressions_free_threading.txt
kumaraditya303 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix comment
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jan 4, 2025
commit 26769576794a08d5ddbcea6b6f55ec079f4e48e4
3 changes: 1 addition & 2 deletions Modules/_asynciomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,8 +1657,6 @@ FutureIter_dealloc(futureiterobject *it)
static PySendResult
FutureIter_am_send_lock_held(futureiterobject *it, PyObject **result)
{
/* arg is unused, see the comment on FutureIter_send for clarification */

PyObject *res;
FutureObj *fut = it->future;
_Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED(fut);
Expand Down Expand Up @@ -1690,6 +1688,7 @@ FutureIter_am_send(futureiterobject *it,
PyObject *Py_UNUSED(arg),
PyObject **result)
{
/* arg is unused, see the comment on FutureIter_send for clarification */
PySendResult res;
Py_BEGIN_CRITICAL_SECTION(it->future);
res = FutureIter_am_send_lock_held(it, result);
Expand Down
Loading
0