use list as temp storage for tasks before filtering

python · kumaraditya303 · Jan 4, 2025 · Dec 21, 2024 · Dec 21, 2024 · Dec 21, 2024
commit 5411a449dec631a9ae199ec7f6065182523b90a4
@@ -3760,23 +3760,28 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop)
     } else {
         Py_INCREF(loop);
     }
-    // First add eager tasks to the set so that we don't miss
+    // First add eager tasks to the list so that we don't miss
     // any tasks which graduates from eager to non-eager
-    // We first add all the tasks to `tasks` set and then filter
-    // out the tasks which are done and return it.
-    PyObject *tasks = PySet_New(state->eager_tasks);
+    // We first add all the tasks to `tasks` list and then filter
+    // out the tasks which are done and return it as a set.
+    PyObject *tasks = PyList_New(0);
     if (tasks == NULL) {
         Py_DECREF(loop);
         return NULL;
     }
+    if (PyList_Extend(tasks, state->eager_tasks) < 0) {
+        Py_DECREF(tasks);
+        Py_DECREF(loop);
+        return NULL;
+    }
     int err = 0;
     ASYNCIO_STATE_LOCK(state);
     struct llist_node *node;
 
     llist_for_each_safe(node, &state->asyncio_tasks_head) {
         TaskObj *task = llist_data(node, TaskObj, task_node);
         Py_INCREF(task);
-        if (PySet_Add(tasks, (PyObject *)task) < 0) {
+        if (PyList_Append(tasks, (PyObject *)task) < 0) {
             Py_DECREF(task);
             Py_DECREF(tasks);
             Py_DECREF(loop);
@@ -3797,7 +3802,7 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop)
     }
     PyObject *item;
     while ((item = PyIter_Next(scheduled_iter)) != NULL) {
-        if (PySet_Add(tasks, item) < 0) {
+        if (PyList_Append(tasks, item) < 0) {
             Py_DECREF(tasks);
             Py_DECREF(loop);
             Py_DECREF(item);
@@ -3807,34 +3812,24 @@ _asyncio_all_tasks_impl(PyObject *module, PyObject *loop)
         Py_DECREF(item);
     }
     Py_DECREF(scheduled_iter);
-    // All the tasks are now in the set, now filter the tasks which are done
+    // All the tasks are now in the list, now filter the tasks which are done
     PyObject *res = PySet_New(NULL);
     if (res == NULL) {
         Py_DECREF(tasks);
         Py_DECREF(loop);
         return NULL;
     }
-    PyObject *iter = PyObject_GetIter(tasks);
 
-    if (iter == NULL) {
-        Py_DECREF(tasks);
-        Py_DECREF(res);
-        Py_DECREF(loop);
-        return NULL;
-    }
-
-    while((item = PyIter_Next(iter)) != NULL) {
-        if (add_one_task(state, res, item, loop) < 0) {
+    for (Py_ssize_t i = 0; i < PyList_GET_SIZE(tasks); i++) {
+        PyObject *task = PyList_GET_ITEM(tasks, i);
+        if (add_one_task(state, res, task, loop) < 0) {
             Py_DECREF(res);
-            Py_DECREF(iter);
             Py_DECREF(tasks);
             Py_DECREF(loop);
-            Py_DECREF(item);
             return NULL;
         }
-        Py_DECREF(item);
     }
-    Py_DECREF(iter);
+
     Py_DECREF(tasks);
     Py_DECREF(loop);
     return res;

diff --git a/Tools/tsan/suppressions_free_threading.txt b/Tools/tsan/suppressions_free_threading.txt
@@ -43,7 +43,7 @@ race_top:write_thread_id
 race_top:PyThreadState_Clear
 # Only seen on macOS, sample: https://gist.github.com/aisk/dda53f5d494a4556c35dde1fce03259c
 race_top:set_default_allocator_unlocked
-# See https://github.com/python/cpython/pull/128147
+# See https://github.com/python/cpython/issues/128421
 race_top:_PyFrame_GetBytecode
 race_top:BaseException_set_tb