8000 gh-121464: Make concurrent iteration over enumerate safe under free-threading by eendebakpt · Pull Request #125734 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-121464: Make concurrent iteration over enumerate safe under free-threading #125734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 13, 2025
Merged

gh-121464: Make concurrent iteration over enumerate safe under free-threading #125734

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
609ce86
Make concurrent iteration over enumerate safe under free-threading
eendebakpt Oct 19, 2024
7cbc12a
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 19, 2024
3902f3b
fix news entry
eendebakpt Oct 19, 2024
ce2315c
relax test
eendebakpt Oct 19, 2024
e42f74f
relax test
eendebakpt Oct 19, 2024
079e6ab
fix exit of critical section
eendebakpt Oct 20, 2024
0d6ce83
Merge branch 'main' into enumerate_ft_v4
eendebakpt Oct 20, 2024
0dd6cd8
format news entry
eendebakpt Oct 20, 2024
d861c35
apply review suggestions
eendebakpt Oct 21, 2024
b3eff15
Merge branch 'main' into enumerate_ft_v4
eendebakpt Jan 4, 2025
167d606
refactor to avoid returning from within a critical section
eendebakpt Jan 4, 2025
23c575d
make sure all threads start iterating at the same moment in the test
eendebakpt Jan 4, 2025
7450a34
remove debug statement
eendebakpt Jan 4, 2025
c12cfa5
Merge branch 'main' into enumerate_ft_v4
eendebakpt Jan 4, 2025
98fb828
Merge branch 'main' into enumerate_ft_v4
eendebakpt Jan 15, 2025
8dd0701
Update Objects/enumobject.c
eendebakpt Jan 15, 2025
a90d5e8
review suggestions
eendebakpt Jan 15, 2025
9b40039
fix test
eendebakpt Jan 15, 2025 8000
d052d2c
Merge branch 'main' into enumerate_ft_v4
eendebakpt Jan 15, 2025
87cbd42
cleanup test
eendebakpt Jan 15, 2025
d4e5779
Merge branch 'main' into enumerate_ft_v4
eendebakpt Mar 5, 2025
2af6ce9
refactor test
eendebakpt Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor test
  • Loading branch information
@eendebakpt
eendebakpt committed Mar 12, 2025
commit 2af6ce93b5589554d30396ad26006a694df61d66
8 changes: 3 additions & 5 deletions Lib/test/test_free_threading/test_enumerate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

from test.support import threading_helper

threading_helper.requires_working_threading(module=True)

class EnumerateThreading(unittest.TestCase):

@threading_helper.reap_threads
@threading_helper.requires_working_threading()
def test_threading(self):
number_of_threads = 10
number_of_iterations = 8
Expand All @@ -29,10 +29,8 @@ def work(enum):
for ii in range(number_of_threads):
worker_threads.append(
Thread(target=work, args=[enum]))
for t in worker_threads:
t.start()
for t in worker_threads:
t.join()
with threading_helper.start_threads(worker_threads):
pass

barrier.reset()

Expand Down
Loading
0