8000 gh-121464: Make concurrent iteration over enumerate safe under free-threading by eendebakpt · Pull Request #125734 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-121464: Make concurrent iteration over enumerate safe under free-threading #125734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 13, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make sure all threads start iterating at the same moment in the test
  • Loading branch information
eendebakpt committed Jan 4, 2025
commit 23c575d917b2f35d3d04df604b8985580b2d2c7f
17 changes: 10 additions & 7 deletions Lib/test/test_free_threading/test_enumerate.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,25 @@ def test_threading(self):
number_of_iterations = 8
n = 100
start = sys.maxsize - 40

def work(enum, start):
workers_enabled = False
def work(enum):
while True:
try:
_ = next(enum)
except StopIteration:
break
if workers_enabled:
print('go!')
try:
_ = next(enum)
except StopIteration:
break

for _ in range(number_of_iterations):
enum = enumerate(range(start, start + n))
worker_threads = []
for ii in range(number_of_threads):
worker_threads.append(
Thread(target=work, args=[enum, start]))
Thread(target=work, args=[enum]))
for t in worker_threads:
t.start()
workers_enabled = True # make sure to start all threads simultaneously
for t in worker_threads:
t.join()

Expand Down
0