8000 gh-125018: Fix role syntax by AA-Turner · Pull Request #125050 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-125018: Fix role syntax #125050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

gh-125018: Fix role syntax #125050

merged 1 commit into from
Oct 7, 2024

Conversation

AA-Turner
Copy link
Member
@AA-Turner AA-Turner commented Oct 7, 2024 •
edited by github-actions bot
Loading

#125027 contains some markup errors, but has been merged.

E.g.:

image

A

📚 Documentation preview 📚: https://cpython-previews--125050.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting core review labels Oct 7, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 7, 2024
Closed
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 7, 2024
@AA-Turner AA-Turner merged commit 10094a5 into python:main Oct 7, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@AA-Turner AA-Turner deleted the docs/importlib-metadata-fixup branch October 7, 2024 16:51
@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 10094a533a947b72d01ed8195dcf540f2e7820ea 3.13

@AA-Turner
Copy link
Member Author

3.13 backports will fail until #125047 is merged.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2024
@AA-Turner @miss-islington
pythongh-125018: Fix role syntax (pythonGH-125050)
d475b32 
(cherry picked from commit 10094a5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
C 8000 opy link
bedevere-app bot commented Oct 7, 2024

GH-125055 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 7, 2024
AA-Turner added a commit that referenced this pull request Oct 7, 2024
@miss-islington @AA-Turner
[3.12] gh-125018: Fix role syntax (GH-125050) (#125055)
d2b3071 
gh-125018: Fix role syntax (GH-125050)
(cherry picked from commit 10094a5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Oct 8, 2024
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2024
@AA-Turner @miss-islington
pythongh-125018: Fix role syntax (pythonGH-125050)
6f78bf1 
(cherry picked from commit 10094a5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Oct 8, 2024

GH-125080 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2024
AA-Turner added a commit that referenced this pull request Oct 8, 2024
@miss-islington @AA-Turner
[3.13] gh-125018: Fix role syntax (GH-125050) (#125080)
d869d54 
gh-125018: Fix role syntax (GH-125050)
(cherry picked from commit 10094a5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

Assignees

@AA-Turner AA-Turner

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @willingc
0