8000 gh-125018: Add importlib.metadata semantic link targets by ncoghlan · Pull Request #125027 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-125018: Add importlib.metadata semantic link targets #125027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 7, 2024
Merged

gh-125018: Add importlib.metadata semantic link targets #125027

merged 6 commits into from
Oct 7, 2024

Conversation

ncoghlan
Copy link
Contributor
@ncoghlan ncoghlan commented Oct 6, 2024 •
edited by github-actions bot
Loading

This allows direct intersphinx references to APIs via references like :func:`importlib.metadata.version`.

📚 Documentation preview 📚: https://cpython-previews--125027.org.readthedocs.build/

@ncoghlan
pythongh-125018: Add importlib.metadata semantic link targets
754c510 
This allows direct intersphinx references to APIs via references
like `` :func:`importlib.metadata.version` ``.
@ncoghlan ncoghlan added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 6, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2024
Closed
@ncoghlan ncoghlan mentioned this pull request Oct 6, 2024
Closed
AA-Turner
AA-Turner reviewed Oct 6, 2024
View reviewed changes
willingc
willingc reviewed Oct 6, 2024
View reviewed changes
Copy link
Contributor
@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ncoghlan.

ncoghlan and others added 2 commits October 7, 2024 16:35
@ncoghlan @webknjaz
Use module docs link in NEWS entry
213179b 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@ncoghlan @AA-Turner
Mark PackageNotFoundError as an exception
8931180 
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ncoghlan
ncoghlan commented Oct 7, 2024
View reviewed changes
Copy link
Contributor Author
@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review comments folks. Mostly accepted and included in the latest push, a few more detailed responses inline.

@ncoghlan
Copy link
Contributor Author
ncoghlan commented Oct 7, 2024

Thanks for the reviews folks. Merging this to get the link targets added, we can always adjust the docs further in future PRs.

@ncoghlan ncoghlan merged commit cda3b5a into python:main Oct 7, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @ncoghlan for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ncoghlan, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cda3b5a576412a8671bbe4c68bb792ec14f1a4b1 3.13

@ncoghlan ncoghlan deleted the gh-125018-importlib-metadata-semantic-refs branch October 7, 2024 13:44
@miss-islington-app
Copy link

Sorry, @ncoghlan, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cda3b5a576412a8671bbe4c68bb792ec14f1a4b1 3.12

ncoghlan added a commit to ncoghlan/cpython that referenced this pull request Oct 7, 2024
@ncoghlan @webknjaz @AA-Turner
pythongh-125018: Add importlib.metadata semantic link targets (python…
c8a8a43 
…#125027)

This allows direct intersphinx references to APIs via references
like `` :func:`importlib.metadata.version` ``.

---------

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
(cherry picked from commit cda3b5a)
@bedevere-app
Copy link
bedevere-app bot commented Oct 7, 2024

GH-125047 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 7, 2024
@bedevere-app
Copy link
bedevere-app bot commented Oct 7, 2024

GH-125048 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 7, 2024
@ncoghlan
Copy link
Contributor Author
ncoghlan commented Oct 7, 2024

3.12 backport is set to automerge, 3.13 backport merge will have to wait until the branch is unlocked post-3.13.0.

ncoghlan added a commit that referenced this pull request Oct 7, 2024
@ncoghlan @webknjaz @AA-Turner
[3.12] gh-125018: Add importlib.metadata semantic link targets (GH-12…
fa32f00 
…5027) (#125048)

This allows direct intersphinx references to APIs via references
like `` :func:`importlib.metadata.version` ``.

---------

(cherry picked from commit cda3b5a)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner AA-Turner mentioned this pull request Oct 7, 2024
Merged
AA-Turner added a commit that referenced this pull request Oct 8, 2024
@ncoghlan @webknjaz C2FC @AA-Turner
[3.13] gh-125018: Add importlib.metadata semantic link targets (GH-12…
b0d01a1 
…5027) (#125047)

gh-125018: Add importlib.metadata semantic link targets (#125027)

This allows direct intersphinx references to APIs via references
like `` :func:`importlib.metadata.version` ``.

(cherry picked from commit cda3b5a)

---------

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@jaraco jaraco mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@willingc willingc willingc left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@ncoghlan ncoghlan

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncoghlan @webknjaz @willingc @AA-Turner
0