8000 GH-120804: Remove `PidfdChildWatcher`, `ThreadedChildWatcher` and `AbstractChildWatcher` from asyncio APIs by kumaraditya303 · Pull Request #120893 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher and AbstractChildWatcher from asyncio APIs #120893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2024
Merged

GH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher and AbstractChildWatcher from asyncio APIs #120893

merged 2 commits into from
Jun 23, 2024

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Jun 23, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2024
Closed
@kumaraditya303 kumaraditya303 merged commit 9d2e1ea into python:main Jun 23, 2024
34 checks passed
@kumaraditya303 kumaraditya303 deleted the watcher branch June 23, 2024 13:08
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@kumaraditya303 @mrahtz
pythonGH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher a…
4d8d2dc 
…nd `AbstractChildWatcher` from asyncio APIs (python#120893)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@kumaraditya303 @noahbkim
pythonGH-120804 8000 : Remove PidfdChildWatcher, ThreadedChildWatcher a…
fe11607 
…nd `AbstractChildWatcher` from asyncio APIs (python#120893)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@kumaraditya303 @estyxx
pythonGH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher a…
11ec705 
…nd `AbstractChildWatcher` from asyncio APIs (python#120893)
@allisonkarlitskaya
Copy link
Contributor
allisonkarlitskaya commented Mar 6, 2025 •
edited
Loading

hi,

Where was it documented that PidfdChildWatcher was deprecated and slated for removal?

https://docs.python.org/3/library/asyncio-policy.html#asyncio.PidfdChildWatcher shows only "added in 3.9". We specifically added a check for this class by name because of the pending deprecation of SafeChildWatcher (which is indeed marked as "Deprecated since version 3.12." on the same page) and now our code is broken with Python 3.14...

See https://bugzilla.redhat.com/show_bug.cgi?id=2350287

@allisonkarlitskaya allisonkarlitskaya mentioned this pull request Mar 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @allisonkarlitskaya
0