8000 GH-120804: Remove `PidfdChildWatcher`, `ThreadedChildWatcher` and `AbstractChildWatcher` from asyncio APIs by kumaraditya303 · Pull Request #120893 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher and AbstractChildWatcher from asyncio APIs #120893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2024
Merged

GH-120804: Remove PidfdChildWatcher, ThreadedChildWatcher and AbstractChildWatcher from asyncio APIs #120893

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b438e52
remove threaded and pidfd child watchers
kumaraditya303 Jun 23, 2024
23112b1
add test
kumaraditya303 Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test
  • Loading branch information
@kumaraditya303
kumaraditya303 committed Jun 23, 2024
commit 23112b18806877028756829ba58728bca5874600
8 changes: 8 additions & 0 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,14 @@ def setUp(self):
self.loop = policy.new_event_loop()
self.set_event_loop(self.loop)

def test_watcher_implementation(self):
loop = self.loop
watcher = loop._watcher
if unix_events.can_use_pidfd():
self.assertIsInstance(watcher, unix_events._PidfdChildWatcher)
else:
self.assertIsInstance(watcher, unix_events._ThreadedChildWatcher)


class SubprocessThreadedWatcherTests(SubprocessWatcherMixin,
test_utils.TestCase):
Expand Down
Loading
0