gh-118986: expose socket.IPV6_RECVERR #118987
Conversation
|
This has missed the 3.14 alpha; may I ask for a review again to have this available next round? @Eclips4 and @jeremyhylton would be suitable reviewers given the history of #120056. |
Misc/NEWS.d/next/Library/2024-05-13-10-09-41.gh-issue-118986.-r4W9h.rst
Outdated
Show resolved
Hide resolved
|
Please, modify the lines stated below to include the cpython/Doc/library/socket.rst Lines 453 to 455 in 0d88b99 |
|
Adjusted as requested. You pointed at the lines for Python 3.14 -- do I read this right that this PR can become part of 3.14 still? |
Yes, you understand that correctly! Python 3.14 is in development stage and two days ago was released the first alpha of 3.14, so we have more than half a year to implement new features for 3.14 version. For more information see https://peps.python.org/pep-0745/ If your question was about backporting to versions 3.12 and 3.13, sorry, we can't do that, because this PR is considered a feature request and versions 3.12 and 3.13 only accept security and bug fixes. |
|
@chrysn, in the future, please avoid force pushes as they make PRs difficult to review. Commits are squashed anyway before merging, so it doesn't matter how many commits you need to complete a PR :) |
You've said that there are two new socket constants, but in fact, this PR contains only one. Did you forget to add the second one? |
|
The issue was originally about adding two constants (I've updated the title but kept the original post). One of the constants was already added after this PR was filed in a different PR (#120056), so when I updated this PR, only one was left. |
|
Thank you! |
This adds two socket option numbers, without which the existing
MSG_ERRQUEUEgives barely any benefits.