8000 gh-117797: Improve `test_descr.test_not_implemented` by sobolevn · Pull Request #117798 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-117797: Improve test_descr.test_not_implemented #117798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2024
Merged

gh-117797: Improve test_descr.test_not_implemented #117798

merged 3 commits into from
Apr 16, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Apr 12, 2024 •
edited by bedevere-app bot
Loading

This module does not have an owner, @vstinner would you please take a look?

@sobolevn sobolevn requested a review from vstinner April 12, 2024 06:22
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Apr 12, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 12, 2024
Closed
vstinner
vstinner reviewed Apr 15, 2024
View reviewed changes
vstinner
vstinner approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix, thanks.

@sobolevn
Copy link
Member Author

Thanks a lot for the review! I fixed a typo in the last commit, now scheduled a merge :)

@sobolevn sobolevn enabled auto-merge (squash) April 16, 2024 07:53
@sobolevn sobolevn merged commit 1a1e013 into python:main Apr 16, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2024
@sobolevn @miss-islington
pythongh-117797: Improve test_descr.test_not_implemented (pythonGH-…
b2e5095 
…117798)

(cherry picked from commit 1a1e013)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link
bedevere-app bot commented Apr 16, 2024

GH-117921 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 16, 2024
sobolevn added a commit that referenced this pull request Apr 16, 2024
@miss-islington @sobolevn
[3.12] gh-117797: Improve test_descr.test_not_implemented (GH-117798)…
44eab29 
… (#117921)

gh-117797: Improve `test_descr.test_not_implemented` (GH-117798)
(cherry picked from commit 1a1e013)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-117797: Improve test_descr.test_not_implemented (python#11…
1f7f794 
…7798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @vstinner
0