10000 Improve `test_descr.test_not_implemented` · Issue #117797 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Improve test_descr.test_not_implemented #117797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Apr 12, 2024 · 0 comments
Closed

Improve test_descr.test_not_implemented #117797

sobolevn opened this issue Apr 12, 2024 · 0 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member
sobolevn commented Apr 12, 2024 •
edited by bedevere-app bot
Loading

Bug report

Right now there are several problems that can be attributed to the long history of this test.

  1. operator name here is not needed:

    cpython/Lib/test/test_descr.py

    Line 4604 in 396b831

    exec(expr, {'x': x, 'y': y, 'operator': operator})
  2. rname here is not used:

    cpython/Lib/test/test_descr.py

    Line 4629 in 396b831

    rname = '__r' + name[2:]
    This means that __r*__ methods are not tested. They were removed 18 years ago in 4886cc3#diff-6b813570d02ae3544e7e0233ae21d647f8e2dc47486495557e8d16c80460e85b I think that adding them back is a good thing

Linked PRs
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Apr 12, 2024
@sobolevn sobolevn self-assigned this Apr 12, 2024
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 12, 2024
@sobolevn
pythongh-117797: Improve test_descr.test_not_implemented
dd9a9fc
@bedevere-app bedevere-app bot mentioned this issue Apr 12, 2024
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Apr 12, 2024
@sobolevn
pythongh-117797: Improve test_descr.test_not_implemented
7ac3ebf
sobolevn added a commit that referenced this issue Apr 16, 2024
@sobolevn
gh-117797: Improve test_descr.test_not_implemented (#117798)
1a1e013
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Apr 16, 2024
@sobolevn @miss-islington
pythongh-117797: Improve test_descr.test_not_implemented (pythonGH-…
b2e5095 
…117798)

(cherry picked from commit 1a1e013)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Apr 16, 2024
Merged
sobolevn added a commit that referenced this issue Apr 16, 2024
@miss-islington @sobolevn
[3.12] gh-117797: Improve test_descr.test_not_implemented (GH-117798)…
44eab29 
… (#117921)

gh-117797: Improve `test_descr.test_not_implemented` (GH-117798)
(cherry picked from commit 1a1e013)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @diegorusso
pythongh-117797: Improve test_descr.test_not_implemented (python#11…
1f7f794 
…7798)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sobolevn
0