GH-116134: JIT aarch64-pc-windows-msvc
#116130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarch64-pc-windows-msvcaarch64-pc-windows-msvc
|
Your team should have access to machines. Check with Mike |
Doesn't look like we do yet... :( |
|
Going to land this, will actually test it when I get access to hardware. |
woodruffw
pushed a commit
to woodruffw-forks/cpython
that referenced
this pull request
Mar 4, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have hardware to test this on yet, but this at least gets things building correctly (like our other WoA CI, we just build it and don't actually run anything).
Since the JIT already has (tested) support for both Windows and AArch64 separately, I'm reasonably confident that this will work out-of-the-box when we finally can get it running somewhere (or that we can get it working with fairly minor tweaks). I've audited the generated code and it seems like there are no glaring issues like we've seen when adding other platforms.
CC: @zooba
aarch64-pc-windows-msvc#116134