8000 ``Tools/cases_generator``: Fix typos and incorrect comments. by Eclips4 · Pull Request #114892 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Tools/cases_generator: Fix typos and incorrect comments. #114892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Tools/cases_generator: Fix typos and incorrect comments. #114892

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad145c
Fix typos
Eclips4 Feb 2, 2024
942b2c2
Address review from Guido
Eclips4 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tools/cases_generator/opcode_id_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Generate the list of opcode IDs.
Reads the instruction definitions from bytecodes.c.
Writes the IDs to opcode._ids.h by default.
Writes the IDs to opcode_ids.h by default.
"""

import argparse
Expand Down
4 changes: 2 additions & 2 deletions Tools/cases_generator/opcode_metadata_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Generate uop metedata.
"""Generate opcode metadata.
Reads the instruction definitions from bytecodes.c.
Writes the metadata to pycore_uop_metadata.h by default.
Writes the metadata to pycore_opcode_metadata.h by default.
Copy link
Member Author
@Eclips4 Eclips4 Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May it worth to write the full path to file (applies to all other files(generators files))?

"""

import argparse
Expand Down
4 changes: 2 additions & 2 deletions Tools/cases_generator/py_metadata_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"""Generate uop metedata.
"""Generate opcode metadata.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add "for Python" to distinguish it from the previous file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Done

Reads the instruction definitions from bytecodes.c.
Writes the metadata to pycore_uop_metadata.h by default.
Writes the metadata to _opcode_metadata.py by default.
"""

import argparse
Expand Down
2 changes: 1 addition & 1 deletion Tools/cases_generator/uop_metadata_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Generate uop metedata.
"""Generate uop metadata.
Reads the instruction definitions from bytecodes.c.
Writes the metadata to pycore_uop_metadata.h by default.
"""
Expand Down
0