Tools/cases_generator: Fix typos and incorrect comments.
#114892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
Feb 2, 2024
| @@ -1,6 +1,6 @@ | |||
| """Generate uop metedata. | |||
| """Generate opcode metadata. | |||
There was a problem hiding this comment.
Maybe add "for Python" to distinguish it from the previous file?
Eclips4
commented
Feb 2, 2024
| Reads the instruction definitions from bytecodes.c. | ||
| Writes the metadata to pycore_uop_metadata.h by default. | ||
| Writes the metadata to pycore_opcode_metadata.h by default. |
There was a problem hiding this comment.
May it worth to write the full path to file (applies to all other files(generators files))?
Fidget-Spinner
approved these changes
Feb 2, 2024
|
Thanks again! |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #114844 and #114522
I hope this is the last change in this series 😄