E670 gh-114271: Fix race in `Thread.join()` by mpage · Pull Request #114839 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-114271: Fix race in Thread.join() #114839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Mar 16, 2024
Merged

gh-114271: Fix race in Thread.join() #114839

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
fb13cf6
Fix race in `Thread.join()`
mpage Jan 26, 2024
b093e5d
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 1, 2024
1039208
Fix NEWS entry
mpage Feb 1, 2024
196081d
Work around c-analyzer limitation
mpage Feb 5, 2024
19d7af1
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Feb 5, 2024
c86d349
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Feb 7, 2024
40e4b36
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Feb 14, 2024
4ed1083
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Feb 14, 2024
34b6065
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Mar 1, 2024
1c82786
Fix two compilation errors post merge
mpage Mar 1, 2024
0e86cf9
Use ThreadHandle as the single abstraction for thread joining
mpage Mar 2, 2024
76bde03
Isolate all logic in _threadmodule
mpage Mar 4, 2024
02123b8
Fix flag
mpage Mar 5, 2024
24c1d47
Note that the once flag serializes both join and set_done
mpage Mar 6, 2024
1a1bfde
Fix unused variable warning
mpage Mar 6, 2024
b3c2c45
Rename ThreadHandleObject to PyThreadHandleObject
mpage Mar 6, 2024
7b9d007
Be consistent with documentation of true values
mpage Mar 6, 2024
5d0dc7a
Threads started using `start_joinable_thread` should be daemon thread…
mpage Mar 6, 2024
11bb826
Remove any remaining handles once the module is cleared
mpage Mar 7, 2024
06f6787
Always have a _ThreadHandle in Thread
mpage Mar 8, 2024
d56f892
Check main thread handle during shutdown
mpage Mar 8, 2024
57e106d
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Mar 8, 2024
2218c0a
Remove vestigial _PyEventRc declarations
mpage Mar 8, 2024
f9d3290
Remove duplicate declaration
mpage Mar 8, 2024
a7095e4
Revert order change in `_DummyThread.is_alive`
mpage Mar 8, 2024
ccd1c2e
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Mar 11, 2024
180300c
Add handles to shutdown list before starting the thread
mpage Mar 11, 2024
c486503
Move some code around to remove need for forward decls
mpage Mar 12, 2024
3121623
Simplify start failure path
mpage Mar 12, 2024
ee96259
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage Mar 15, 2024
dc57ed2
Use infinitive in docstring for _shutdown
mpage Mar 15, 2024
48b86ae
Update comment for _make_thread_handle
mpage Mar 15, 2024
9a8ea9b
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrou Mar 16, 2024
339b2e6
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrou Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into gh-114271-remove-tstate_lock
  • Loading branch information
@mpage
mpage committed Mar 15, 2024
commit ee962590ded8a24a8d8b4c9c00d65afb443fc6b9

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.
0