-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
gh-114271: Fix race in Thread.join()
#114839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fb13cf6
Fix race in `Thread.join()`
mpage b093e5d
📜🤖 Added by blurb_it.
blurb-it[bot] 1039208
Fix NEWS entry
mpage 196081d
Work around c-analyzer limitation
mpage 19d7af1
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage c86d349
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 40e4b36
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 4ed1083
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 34b6065
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 1c82786
Fix two compilation errors post merge
mpage 0e86cf9
Use ThreadHandle as the single abstraction for thread joining
mpage 76bde03
Isolate all logic in _threadmodule
mpage 02123b8
Fix flag
mpage 24c1d47
Note that the once flag serializes both join and set_done
mpage 1a1bfde
Fix unused variable warning
mpage b3c2c45
Rename ThreadHandleObject to PyThreadHandleObject
mpage 7b9d007
Be consistent with documentation of true values
mpage 5d0dc7a
Threads started using `start_joinable_thread` should be daemon thread…
mpage 11bb826
Remove any remaining handles once the module is cleared
mpage 06f6787
Always have a _ThreadHandle in Thread
mpage d56f892
Check main thread handle during shutdown
mpage 57e106d
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 2218c0a
Remove vestigial _PyEventRc declarations
mpage f9d3290
Remove duplicate declaration
mpage a7095e4
Revert order change in `_DummyThread.is_alive`
mpage ccd1c2e
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage 180300c
Add handles to shutdown list before starting the thread
mpage c486503
Move some code around to remove need for forward decls
mpage 3121623
Simplify start failure path
mpage ee96259
Merge branch 'main' into gh-114271-remove-tstate_lock
mpage dc57ed2
Use infinitive in docstring for _shutdown
mpage 48b86ae
Update comment for _make_thread_handle
mpage 9a8ea9b
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrou 339b2e6
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use ThreadHandle as the single abstraction for thread joining
- Loading branch information
commit 0e86cf97670d54391cf9f3a2fa444009e8b0a97c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.