8000 gh-112240: Add option to calendar module CLI to specify the weekday to start each week by planet36 · Pull Request #112241 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112240: Add option to calendar module CLI to specify the weekday to start each week #112241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 29, 2024
Merged

gh-112240: Add option to calendar module CLI to specify the weekday to start each week #112241

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
739558c
Add option to calendar module CLI to specify the weekday to start eac…
planet36 Nov 18, 2023
88bd9a9
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 18, 2023
343ec0a
Merge branch 'main' of https://github.com/python/cpython into fix-iss…
planet36 Dec 5, 2023
6331766
Remove year restriction from docs
planet36 Dec 5, 2023
7a5e02e
Remove validation of CLI option firstweekday
planet36 Dec 5, 2023
9debe69
Merge branch 'main' of https://github.com/python/cpython into fix-iss…
planet36 Dec 6, 2023
8d15173
Merge branch 'main' of https://github.com/python/cpython into fix-iss…
planet36 Dec 6, 2023
3ee7d19
Merge branch 'main' into fix-issue-112240
planet36 Dec 6, 2023
a60bab9
Merge branch 'python:main' into fix-issue-112240
planet36 Jan 12, 2024
cf2c335
Merge branch 'main' of https://github.com/python/cpython into fix-iss…
planet36 Jan 28, 2024
3a15bde
Rename CLI long option to --first-weekday
planet36 Jan 28, 2024
56c6ed4
Describe weekday number convention in docs and help message
planet36 Jan 28, 2024
7cc4291
Update Doc/library/calendar.rst
planet36 Jan 29, 2024
022ce9a
Restore comment per PR feedback
planet36 Jan 29, 2024
c10c2c9
Merge branch 'main' of https://github.com/python/cpython into fix-iss…
planet36 Jan 29, 2024
baf6c77
Merge branch 'main' into fix-issue-112240
serhiy-storchaka Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove validation of CLI option firstweekday
  • Loading branch information
@planet36
planet36 committed Dec 6, 2023
commit 7a5e02e742d1ebade083d300fe0e552f3087d943
3 changes: 0 additions & 3 deletions Lib/calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,9 +758,6 @@ def main(args=None):

locale = options.locale, options.encoding

if not MONDAY <= options.firstweekday <= SUNDAY:
raise IllegalWeekdayError(options.firstweekday)

if options.type == "html":
if options.month:
parser.error("incorrect number of arguments")
Expand Down
4 changes: 0 additions & 4 deletions Lib/test/test_calendar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,12 +1001,8 @@ def test_illegal_arguments(self):
self.assertFailure('2004', 'spam')
self.assertFailure('2004', '1', 'spam')
self.assertFailure('2004', '1', '1')
self.assertFailure('2004', '0')
self.assertFailure('2004', '13')
self.assertFailure('2004', '1', '1', 'spam')
self.assertFailure('-t', 'html', '2004', '1')
self.assertFailure('--firstweekday', '-1')
self.assertFailure('--firstweekday', '7')

def test_output_current_year(self):
for run in self.runners:
Expand Down
0