8000 gh-112240: Add option to calendar module CLI to specify the weekday to start each week by planet36 · Pull Request #112241 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-112240: Add option to calendar module CLI to specify the weekday to start each week #112241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jan 29, 2024
Merged

gh-112240: Add option to calendar module CLI to specify the weekday to start each week #112241

merged 16 commits into from
Jan 29, 2024

Conversation

planet36
Copy link
Contributor
@planet36 planet36 commented Nov 18, 2023 •
edited
Loading

This PR adds --first-weekday and -f options to the calendar module CLI. These take an integer representing the weekday to start each week.

📚 Documentation preview 📚: https://cpython-previews--112241.org.readthedocs.build/

@ghost
Copy link
ghost commented Nov 18, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link
bedevere-app bot commented Nov 18, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2023
Closed
@AA-Turner AA-Turner self-requested a review January 23, 2024 01:01
serhiy-storchaka
serhiy-storchaka reviewed Jan 28, 2024
View reviewed changes
hugovk
hugovk reviewed Jan 28, 2024
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Jan 28, 2024
View reviewed changes
@planet36 planet36 mentioned this pull request Jan 29, 2024
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) January 29, 2024 16:05
@serhiy-storchaka serhiy-storchaka merged commit 2c089b0 into python:main Jan 29, 2024
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @planet36. And congratulate you with your first commit in CPython. Well, technically not first, but actually first.

@planet36 planet36 deleted the fix-issue-112240 branch January 30, 2024 00:56
@hugovk hugovk mentioned this pull request Feb 2, 2024
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@planet36 @aisk
pythongh-112240: Add option to calendar module CLI to specify the wee…
629486e 
…kday to start each week (pythonGH-112241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@planet36 @serhiy-storchaka @hugovk
0