8000 [3.12] Fix undefined behaviour in datetime.time.fromisoformat() (GH-111982) by miss-islington · Pull Request #111992 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.12] Fix undefined behaviour in datetime.time.fromisoformat() (GH-111982) #111992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2023
Merged

[3.12] Fix undefined behaviour in datetime.time.fromisoformat() (GH-111982) #111992

merged 1 commit into from
Nov 12, 2023

Conversation

miss-islington
Copy link
Contributor

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters thomas@python.org

@Yhg1s @miss-islington
Fix undefined behaviour in datetime.time.fromisoformat() (pythonGH-11…
0be1f1b 
…1982)

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-app bedevere-app bot mentioned this pull request Nov 12, 2023
Merged
@Yhg1s Yhg1s enabled auto-merge (squash) November 12, 2023 00:06
@Yhg1s Yhg1s merged commit 1afc4dc into python:3.12 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
< 3481 div id="partial-users-participants" class="discussion-sidebar-item">
2 participants
@miss-islington @Yhg1s
0