8000 Fix undefined behaviour in datetime.time.fromisoformat() by Yhg1s · Pull Request #111982 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

8000 Fix undefined behaviour in datetime.time.fromisoformat() #111982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2023
Merged

Fix undefined behaviour in datetime.time.fromisoformat() #111982

merged 1 commit into from
Nov 11, 2023

Conversation

Yhg1s
Copy link
Member
@Yhg1s Yhg1s commented Nov 11, 2023

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).

@Yhg1s
Fix undefined behaviour in datetime.time.fromisoformat() when parsing a
b6dcbe4 
string without a timezone. 'tzoffset' is not assigned to by
parse_isoformat_time if it returns 0, but time_fromisoformat then passes
tzoffset to another function, which is undefined behaviour (even if the
function in question does not use the value).
8000 @Yhg1s Yhg1s added skip issue skip news 3.11 only security fixes 3.12 only security fixes labels Nov 11, 2023
pganssle
pganssle approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member
@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was always supposed to be assigned zero anyway, I think. Probably either missed the assignment, or was confused about the syntax of defining multiple variables on one line. I would not put either mistake by myself, assuming I wrote this in the first place 😅

@Yhg1s
Copy link
Member Author
Yhg1s commented Nov 11, 2023

Yeah, the other call to the two functions (datetime_fromisoformat) does initialize tzoffset, so I assumed it was a mistake :)

@Yhg1s Yhg1s merged commit 21615f7 into python:main Nov 11, 2023
@Yhg1s Yhg1s added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes and removed 3.11 only security fixes 3.12 only security fixes labels Nov 12, 2023
@miss-islington-app
Copy link

Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Yhg1s for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2023
@Yhg1s @miss-islington
Fix undefined behaviour in datetime.time.fromisoformat() (pythonGH-11…
13cd2bf 
…1982)

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Nov 12, 2023

GH-111991 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2023
@Yhg1s @miss-islington
Fix undefined behaviour in datetime.time.fromisoformat() (pythonGH-11…
0be1f1b 
…1982)

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters <thomas@python.org>
@bedevere-app
Copy link
bedevere-app bot commented Nov 12, 2023

GH-111992 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 12, 2023
Yhg1s added a commit that referenced this pull request Nov 12, 2023
@miss-islington @Yhg1s
[3.11] Fix undefined behaviour in datetime.time.fromisoformat() (GH-1…
5a6d1db 
…11982) (#111991)

Fix undefined behaviour in datetime.time.fromisoformat() (GH-111982)

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters <thomas@python.org>
Yhg1s added a commit that referenced this pull request Nov 12, 2023
@miss-islington @Yhg1s
[3.12] Fix undefined behaviour in datetime.time.fromisoformat() (GH-1… 8000
1afc4dc 
…11982) (#111992)

Fix undefined behaviour in datetime.time.fromisoformat() (GH-111982)

Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
(cherry picked from commit 21615f7)

Co-authored-by: T. Wouters <thomas@python.org>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@Yhg1s @aisk
Fix undefined behaviour in datetime.time.fromisoformat() (python#111982)
c62c485 
Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@Yhg1s @Glyphack
Fix undefined behaviour in datetime.time.fromisoformat() (python#111982)
4b1ea74 
Fix undefined behaviour in datetime.time.fromisoformat() when parsing a string without a timezone. 'tzoffset' is not assigned to by parse_isoformat_time if it returns 0, but time_fromisoformat then passes tzoffset to another function, which is undefined behaviour (even if the function in question does not use the value).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle pganssle approved these changes

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yhg1s @pganssle
0