10000 gh-105535 Document potential performance trap during enum creation by nicky-eng · Pull Request #107119 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-105535 Document potential performance trap during enum creation #107119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 8, 2024
Merged

gh-105535 Document potential performance trap during enum creation #107119

merged 11 commits into from
Mar 8, 2024

Conversation

nicky-eng
Copy link
Contributor
@nicky-eng nicky-eng commented Jul 23, 2023 •
edited by github-actions bot
Loading

Fix issue #105535

Document potential performance trap during enum creation.

📚 Documentation preview 📚: https://cpython-previews--107119.org.readthedocs.build/

@nicky-eng nicky-eng requested a review from ethanfurman as a code owner July 23, 2023 10:34
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 23, 2023
@ghost
Copy link
ghost commented Jul 23, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

evildmp
evildmp reviewed Jul 23, 2023
View reviewed changes
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 23, 2023
ethanfurman
ethanfurman reviewed Jul 24, 2023
View reviewed changes
@ethanfurman ethanfurman requested a review from CAM-Gerlach July 24, 2023 18:45
evildmp
evildmp suggested changes Jul 24, 2023
View reviewed changes
@ethanfurman ethanfurman self-assigned this Jul 24, 2023
ethanfurman
ethanfurman reviewed Jul 24, 2023
View reviewed changes
@ethanfurman
Copy link
Member

Thoughts on making this an actual warning box?

hugovk
hugovk reviewed Jul 24, 2023
View reviewed changes
ethanfurman
ethanfurman reviewed Jul 25, 2023
View reviewed changes
@ethanfurman
Update Doc/library/enum.rst
c89ebd4 
attempt to fix dataclass link
ethanfurman
ethanfurman reviewed Mar 4, 2024
View reviewed changes
ethanfurman
ethanfurman reviewed Mar 4, 2024
View reviewed changes
hugovk
hugovk reviewed Mar 5, 2024
View reviewed changes
@ethanfurman @hugovk
re-add sunder versions of name and value
baf05a0 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@ethanfurman
Copy link
Member

@hugovk, thanks, I missed that those were the sunder versions when I merged them.

hugovk
hugovk reviewed Mar 5, 2024
View reviewed changes
@ethanfurman @hugovk
Update Doc/library/enum.rst
43cc68c 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@ethanfurman ethanfurman merged commit 601f3a7 into python:main Mar 8, 2024
@miss-islington-app
Copy link

Thanks @nicky-eng for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2024
@nicky-eng @ethanfurman
@hugovk @miss-islington
pythongh-105535 Document potential performance trap during enum creat…
6857f9a 
…ion (pythonGH-107119)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 8, 2024

GH-116511 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 8, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 8, 2024
@nicky-eng @ethanfurman
@hugovk @miss-islington
pythongh-105535 Document potential performance trap during enum creat…
7ba696e 
…ion (pythonGH-107119)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 8, 2024

GH-116512 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Mar 8, 2024
ethanfurman added a commit that referenced this pull request Mar 9, 2024
@miss-islington @nicky-eng
@ethanfurman @hugovk
[3.12] gh-105535 Document potential performance trap during enum crea…
d5d86e2 
…tion (GH-107119) (GH116511)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ethanfurman added a commit that referenced this pull request Mar 9, 2024
@miss-islington @nicky-eng
@ethanfurman @hugovk
[3.11] gh-105535 Document potential performance trap during enum crea…
232b085 
…tion (GH-107119) (GH-116512)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@nicky-eng @ethanfurman
@hugovk @adorilson
pythongh-105535 Document potential performance trap during enum creat…
6ea639c 
…ion (pythonGH-107119)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@nicky-eng @ethanfurman
@hugovk @diegorusso
pythongh-105535 Document potential performance trap during enum creat…
ac74124 
…ion (pythonGH-107119)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfurman ethanfurman ethanfurman left review comments

@evildmp evildmp evildmp approved these changes

@hugovk hugovk hugovk approved these changes

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicky-eng @ethanfurman @evildmp @hugovk @bedevere-bot
0