8000 Document that enums with unhashable members are created non-performantly · Issue #105535 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Document that enums with unhashable members are created non-performantly #105535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mzhu22 opened this issue Jun 8, 2023 · 4 comments
Closed

Document that enums with unhashable members are created non-performantly #105535

mzhu22 opened this issue Jun 8, 2023 · 4 comments
Labels
docs Documentation in the Doc dir

Comments

@mzhu22
Copy link
mzhu22 commented Jun 8, 2023 •
edited by bedevere-app bot
Loading

Documentation

#28907 fixes enum creation taking quadratic time relative to the number of members, but only for members whose values are hashable. If not fixed, ideally this would be documented somewhere as it could potentially be a big performance trap

Linked PRs
@mzhu22 mzhu22 added the docs Documentation in the Doc dir label Jun 8, 2023
@nicky-eng
Copy link
Contributor

I will try to create a pull request for this issue. I think it will be done by the end of the day.

nicky-eng added a commit to nicky-eng/cpython that referenced this issue Jul 23, 2023
@nicky-eng
pythongh-105535 Document potential performance trap during enum creation
d433f21
@nicky-eng nicky-eng mentioned this issue Jul 23, 2023
Merged
nicky-eng added a commit to nicky-eng/cpython that referenced this issue Jul 23, 2023
@nicky-eng
pythongh-105535: Add warning about quadratical growth
981eaca
@ethanfurman
Copy link
Member

@mzhu22: Out of curiosity, do you have an actual use-case that uses many unhashable values?

@mzhu22
Copy link
Author
mzhu22 commented Jul 24, 2023 •
edited
Loading

@ethanfurman So not a use-case of unhashable values, but rather an example of the performance trap.

We have a use-case of dynamically generating Enums from user data. Originally the enum member values were strings, but we switched to dataclasses to include additional metadata. For some corner cases where enums had a lot of values, we noticed a dramatic performance hit, until we looked into it, and made the dataclasses immutable.

@ethanfurman
Copy link
Member

Definitely a good reason for the warning.

ethanfurman added a commit that referenced this issue Mar 8, 2024
@nicky-eng @ethanfurman @hugovk
gh-105535 Document potential performance trap during enum creation (G…
601f3a7 
…H-107119)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 8, 2024
@nicky-eng @ethanfurman
@hugovk @miss-islington
pythongh-105535 Document potential performance trap during enum creat…
6857f9a 
…ion (pythonGH-107119)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 8, 2024
@nicky-eng @ethanfurman
@hugovk @miss-islington
pythongh-105535 Document potential performance trap during enum creat…
7ba696e 
…ion (pythonGH-107119)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Mar 8, 2024
Merged
Merged
ethanfurman added a commit that referenced this issue Mar 9, 2024
@miss-islington @nicky-eng
@ethanfurman @hugovk
[3.12] gh-105535 Document potential performance trap during enum crea…
d5d86e2 
…tion (GH-107119) (GH116511)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ethanfurman added a commit that referenced this issue Mar 9, 2024
@miss-islington @nicky-eng
@ethanfurman @hugovk
[3.11] gh-105535 Document potential performance trap during enum crea…
232b085 
…tion (GH-107119) (GH-116512)

(cherry picked from commit 601f3a7)

Co-authored-by: Nicolas A. Oyarzabal <79150521+nicky-eng@users.noreply.github.com>
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@nicky-eng @ethanfurman
@hugovk @adorilson
pythongh-105535 Document potential performance trap during enum creat…
6ea639c 
…ion (pythonGH-107119)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@nicky-eng @ethanfurman
@hugovk @diegorusso
pythongh-105535 Document potential performance trap during enum creat…
ac74124 
…ion (pythonGH-107119)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethanfurman @mzhu22 @nicky-eng
0