Remove caching of Path.parts

python · barneygale · Apr 9, 2023 · Mar 6, 2023 · Mar 6, 2023 · Mar 6, 2023
commit c8d4b384e6106cb486c5f5e4cf1be1fc99225ebf
@@ -248,7 +248,7 @@ class PurePath(object):
     """
     __slots__ = (
         '_raw_path', '_drv', '_root', '_tail_cached',
-        '_str', '_hash', '_parts_tuple', '_parts_normcase_cached',
+        '_str', '_hash', '_parts_normcase_cached',
     )
     _flavour = os.path
 
@@ -544,7 +544,7 @@ def relative_to(self, other, /, *_deprecated, walk_up=False):
             raise ValueError(f"{str(self)!r} and {str(other)!r} have different anchors")
         if step and not walk_up:
             raise ValueError(f"{str(self)!r} is not in the subpath of {str(other)!r}")
-        parts = ('..',) * step + self.parts[len(path.parts):]
+        parts = ['..'] * step + self._tail[len(path._tail):]
         return path_cls(*parts)
 
     def is_relative_to(self, other, /, *_deprecated):
@@ -563,16 +563,10 @@ def is_relative_to(self, other, /, *_deprecated):
     def parts(self):
         """An object providing sequence-like access to the
         components in the filesystem path."""
-        # We cache the tuple to avoid building a new one each time .parts
-        # is accessed.  XXX is this necessary?
-        try:
-            return self._parts_tuple
-        except AttributeError:
-            if self.drive or self.root:
-                self._parts_tuple = (self.drive + self.root,) + tuple(self._tail)
-            else:
-                self._parts_tuple = tuple(self._tail)
-            return self._parts_tuple
+        if self.drive or self.root:
+            return (self.drive + self.root,) + tuple(self._tail)
+        else:
+            return tuple(self._tail)
 
     def joinpath(self, *args):
         """Combine this path with one or several arguments, and return a

@@ -416,8 +416,6 @@ def test_parts_common(self):
         p = P('a/b')
         parts = p.parts
         self.assertEqual(parts, ('a', 'b'))
-        # The object gets reused.
-        self.assertIs(parts, p.parts)
         # When the path is absolute, the anchor is a separate part.
         p = P('/a/b')
         parts = p.parts