GH-101362: Omit path anchor from pathlib.PurePath()._parts
#102476
Jump to bottom
8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve performance of path construction by skipping the addition of the path anchor (`drive + root`) to the internal `_parts` list. This change allows us to simplify the implementations of `joinpath()`, `name`, `parent`, and `parents` a little. The public `parts` tuple is unaffected.
|
I'm not sure about this change - I don't like how it makes edit: addressed by renaming |
|
Updated timings: Something like a 10% speedup. |
AlexWaygood
reviewed
Apr 8, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
…ythonGH-102476) Improve performance of path construction by skipping the addition of the path anchor (`drive + root`) to the internal `_parts` list. Rename this attribute to `_tail` for clarity.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Apr 18, 2023
…ythonGH-102476) Improve performance of path construction by skipping the addition of the path anchor (`drive + root`) to the internal `_parts` list. Rename this attribute to `_tail` for clarity.
anjakefala
added a commit
to saulpw/visidata
that referenced
this pull request
Jun 27, 2023
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
anjakefala
added a commit
to saulpw/visidata
that referenced
this pull request
Jun 27, 2023
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
anjakefala
added a commit
to saulpw/visidata
that referenced
this pull request
Jul 16, 2023
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
anjakefala
added a commit
to saulpw/visidata
that referenced
this pull request
Jul 17, 2023
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
anjakefala
added a commit
to saulpw/visidata
that referenced
this pull request
Jul 17, 2023
`pathlib.Path._parts` has been removed in Python 3.12: python/cpython#102476 Switch to pathlib.Path.parts which is a tuple. Closes #1934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of path construction by skipping the addition of the path anchor (
drive + root) to the internal_partslist. Rename this attribute to_tailfor clarity.Also:
name,parent, andparentsa little._make_child_relpath()by building the new string path with naive string concatination rather than_format_parsed_parts().__hash__()and__eq__()by referring to the unsplit case-normalized path.__lt__()etc by referring to the naively split case-normalized path (i.e. split onsepwithout consideration of anchor)The public
partstuple is unaffected.