fix autogenerated element #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays start with alpha char
yannickfunk
approved these changes
May 16, 2022
philippjfr
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#395 was a temporary fix but this should be the real fix that closes #370 and other issues reporting errors with
querySelectorselecting elements starting with a-[1-9]value. This fixes the underlying issue.We were using this.constructor.name that doesn't seem to work well with the current config of
terser. Independently of that, the goal here was to generate a meaningful unique id. We can do that with just the static string (at least I can't come up with really strong reasons for having the id to change based on the class name, besides personal taste for semantics).