8000 remove terser since it's breaking specific examples by fpliger · Pull Request #395 · pyscript/pyscript · GitHub
[go: up one dir, main page]
Skip to content

remove terser since it's breaking specific examples #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

remove terser since it's breaking specific examples #395

merged 1 commit into from
May 16, 2022

Conversation

fpliger
Copy link
Contributor
@fpliger fpliger commented May 16, 2022

No description provided.

@fpliger fpliger requested a review from philippjfr May 16, 2022 15:28
@yannickfunk
Copy link
Contributor

Is this related to #370 ?

@fpliger
Copy link
Contributor Author
fpliger commented May 16, 2022

Yes, this should be related to #370 #362 and probably some others.. This is just a quick fix, we'll probably need to investigate a little more.

@yannickfunk
Copy link
Contributor
yannickfunk commented May 16, 2022 •
edited
Loading

At least for #370 the problem is that constructor.name breaks in minified code. I provided a possible fix there. Is there other code which breaks?

@fpliger
Copy link
Contributor Author
fpliger commented May 16, 2022

All related to the same issue.

@fpliger fpliger merged commit 8670f96 into main May 16, 2022
@fpliger fpliger deleted the fpliger/362_build_broken_vs_dev branch May 16, 2022 15:58
This was referenced May 16, 2022
Closed
Closed
Merged
@fpliger fpliger added the tag: tooling Related to the configuration of infrastructure and tooling label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pww217 pww217 pww217 approved these changes

@yannickfunk yannickfunk yannickfunk approved these changes

@philippjfr philippjfr Awaiting requested review from philippjfr

Assignees
4EEE No one assigned
Labels
tag: tooling Related to the configuration of infrastructure and tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpliger @yannickfunk @pww217
0