add config file for pre-commit #235
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Looks good to me! I think we agreed to add black formatting but I'll let @fpliger confirm and merge.
|
Would also be +1 on adding isort as suggested in #201 |
|
Alright they have documentation for that but I'm not sure which arguments you'd want to use https://pycqa.github.io/isort/docs/configuration/pre-commit.html |
…nto add-precommit-config
for more information, see https://pre-commit.ci
|
Alright that seemed to work and isort modified a number of files itself, hence the 10 new file changes. I added just the regular python hook. |
There was a problem hiding this comment.
lgtm. I'd keep the linted files out of this PR and have a follow up PR (I've done that in my related PR that I just mentioned), mostly for easy of reading... Also, the formatting I added in that PR may clash with this one..
Anyway, not a big deal. We can fix later no matter what route you choose. Thank you for this! 💯
Simply adds a yaml that tells the Github app for pre-commit to run the Black python linting hook. Add other hooks as required.
This is separate from Github Actions - it runs as an app in the repo/org.
We also runner
prettierfor readme formatting in some repos, as a suggestion.